addressed PR comments and added triggerBulkCancel in node SDK to canc…

…el events in bulk
novuhq · Aug 11, 2024 · 8a4abc7 · 8a4abc7
1 parent 6f9388b
commit 8a4abc7
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/apps/api/src/app/events/events.controller.ts b/apps/api/src/app/events/events.controller.ts
@@ -214,7 +214,7 @@ export class EventsController {
   @ThrottlerCost(ApiRateLimitCostEnum.BULK)
   @Post('/trigger/bulk-cancel')
   @ApiOkResponse({
-    type: TriggerBulkCancelResponseDto,
+    type: [TriggerBulkCancelResponseDto],
   })
   @ApiOperation({
     summary: 'Bulk Cancel triggered event',

diff --git a/apps/api/src/app/events/usecases/process-bulk-cancel/process-bulk-cancel.usecase.ts b/apps/api/src/app/events/usecases/process-bulk-cancel/process-bulk-cancel.usecase.ts
@@ -7,7 +7,7 @@ import { ProcessBulkCancelCommand } from './process-bulk-cancel.command';
 export class ProcessBulkCancel {
   constructor(private cancelDelayed: CancelDelayed) {}
 
-  async execute(command: ProcessBulkCancelCommand) {
+  async execute(command: ProcessBulkCancelCommand): Promise<TriggerBulkCancelResponseDto[]> {
     const results: TriggerBulkCancelResponseDto[] = [];
 
     for (const transactionId of command.transactionIds) {

diff --git a/packages/node/src/lib/events/events.ts b/packages/node/src/lib/events/events.ts
@@ -47,4 +47,10 @@ export class Events extends WithHttp implements IEvents {
   async cancel(transactionId: string) {
     return await this.http.delete(`/events/trigger/${transactionId}`);
   }
+
+  async triggerBulkCancel(transactionIds: string[]) {
+    return await this.http.post(`/events/trigger/bulk-cancel`, {
+      transactionIds,
+    });
+  }
 }