chore: Upgrade to pnpm 9, add conventional commit PR title linting (#…

…5598) * chore: Upgrde pnpm engine & corepack version * chore: Use workspace protocol * chore: Upgrade lockfile * chore: Use consistent version for @novu/novui * build: Add convention commit PR title linter workflow * test: PR title lint workflow * fix: copy * test: action * test: wf * fix: add missing id * fix: workflow * fix: wf * fix: scopes * test: logging * fix: checkout code * fix: command * fix: pnpm * fix: action * fix: scopes * fix: redudnancy * fix: review action * fix: add release version * fix: spelling * revert: test * chore: release * feat: add from package script * Revert "chore: release" This reverts commit 9696a96. * refactor: Remove redundant pnpm version from gh actions * chore: Upgrade all Dockerfile pnpm versions * chore: auto commit * chore: auto commit * chore: auto commit * chore: update publish and release scripts * chore: remove dry-run flag from publish command * ci: remove duplicate pull_request trigger * ci: update workflow to trigger on pull request actions --------- Co-authored-by: Dima Grossman <[email protected]>
novuhq · May 20, 2024 · 898ca79 · 898ca79
1 parent 8134535
commit 898ca79
Show file tree

Hide file tree

Showing 52 changed files with 41,339 additions and 36,484 deletions.
diff --git a/.cspell.json b/.cspell.json
@@ -666,6 +666,8 @@
     "automerge",
     "novui",
     "tsup",
+    "marocchino",
+    "amannn",
     "pandabox"
   ],
   "flagWords": [],

diff --git a/.github/actions/setup-project/action.yml b/.github/actions/setup-project/action.yml
@@ -27,7 +27,9 @@ runs:
     - name: ⚙️ Setup kernel for react native, increase watchers
       shell: bash
       run: echo fs.inotify.max_user_watches=524288 | sudo tee -a /etc/sysctl.conf && sudo sysctl -p
-    - uses: pnpm/action-setup@v2
+
+    - name: Install pnpm
+      uses: pnpm/action-setup@v3
 
     - uses: actions/setup-node@v3
       name: ⚙️ Setup Node Version

diff --git a/.github/workflows/community-releases.yml b/.github/workflows/community-releases.yml
@@ -42,8 +42,7 @@ jobs:
 
       - name: Install pnpm
         uses: pnpm/action-setup@v3
-        with:
-          version: 8.9.0
+
       - name: Use Node.js
         uses: actions/setup-node@v4
         with:

diff --git a/.github/workflows/conventional-commit.yml b/.github/workflows/conventional-commit.yml
@@ -0,0 +1,70 @@
+name: "Lint PR title"
+
+on:
+  pull_request_target:
+    types:
+      - opened
+      - edited
+      - synchronize
+  pull_request:
+    types:
+      - opened
+      - edited
+      - synchronize
+
+permissions:
+  pull-requests: write
+
+jobs:
+  main:
+    name: Validate PR titles
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v4
+
+      - name: Install pnpm
+        uses: pnpm/action-setup@v3
+
+      - name: Generate scopes
+        id: generate_scopes
+        run: |
+          scopes=$(pnpm m ls --json --depth=-1 | grep "name" | cut -d":" -f2 | grep "@novu" | cut -d"/" -f2 | grep "\"" | cut -d"\"" -f1)
+          echo 'SCOPES<<EOF' >> $GITHUB_ENV
+          echo "$scopes" >> $GITHUB_ENV
+          echo 'EOF' >> $GITHUB_ENV
+
+      - uses: amannn/action-semantic-pull-request@v5
+        id: lint_pr_title
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        with:
+          scopes: |
+            ${{ env.SCOPES }}
+
+      - uses: marocchino/sticky-pull-request-comment@v2
+        # When the previous steps fails, the workflow would stop. By adding this
+        # condition you can continue the execution with the populated error message.
+        if: always() && (steps.lint_pr_title.outputs.error_message != null)
+        with:
+          header: pr-title-lint-error
+          message: |
+            Hey there and thank you for opening this pull request! 👋
+            
+            We require pull request titles to follow the [Conventional Commits specification](https://www.conventionalcommits.org/en/v1.0.0/) and it looks like your proposed title needs to be adjusted.
+
+            Your PR title is: `${{ github.event.pull_request.title }}`
+            It should be something like: `feat(scope): Add fancy new feature`
+
+            Details:
+            
+            ```
+            ${{ steps.lint_pr_title.outputs.error_message }}
+            ```
+
+      # Delete a previous comment when the issue has been resolved
+      - if: ${{ steps.lint_pr_title.outputs.error_message == null }}
+        uses: marocchino/sticky-pull-request-comment@v2
+        with:   
+          header: pr-title-lint-error
+          delete: true
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -15,7 +15,7 @@ jobs:
       - name: 'Checkout Repository'
         uses: actions/checkout@v3
       - name: 'Dependency Review'
-        uses: actions/dependency-review-action@v3
+        uses: actions/dependency-review-action@v4
 
   spellcheck:
     name: Spell check

diff --git a/.gitpod.dockerfile b/.gitpod.dockerfile
@@ -1,4 +1,4 @@
 FROM gitpod/workspace-mongodb
 
 RUN sudo apt-get update  && sudo apt-get install -y redis-server  && sudo rm -rf /var/lib/apt/lists/*
-RUN npm install -g pnpm@8.9.0
+RUN npm install -g pnpm@9.1.1
diff --git a/.source b/.source
diff --git a/apps/api/Dockerfile b/apps/api/Dockerfile
@@ -4,7 +4,7 @@ RUN apk add g++ make py3-pip
 ENV NX_DAEMON=false
 
 RUN npm i pm2 -g
-RUN npm --no-update-notifier --no-fund --global install pnpm@8.9.0
+RUN npm --no-update-notifier --no-fund --global install pnpm@9.1.1
 RUN pnpm --version
 
 USER 1000

diff --git a/apps/api/package.json b/apps/api/package.json
@@ -41,13 +41,13 @@
     "@nestjs/swagger": "^7.1.8",
     "@nestjs/terminus": "^10.0.1",
     "@nestjs/throttler": "^5.0.1",
-    "@novu/application-generic": "^0.24.2",
-    "@novu/dal": "^0.24.2",
-    "@novu/echo": "^0.0.1-alpha.25",
-    "@novu/node": "^0.24.2",
-    "@novu/shared": "^0.24.2",
-    "@novu/stateless": "^0.24.2",
-    "@novu/testing": "^0.24.2",
+    "@novu/application-generic": "workspace:",
+    "@novu/dal": "workspace:",
+    "@novu/echo": "workspace:",
+    "@novu/node": "workspace:",
+    "@novu/shared": "workspace:",
+    "@novu/stateless": "workspace:",
+    "@novu/testing": "workspace:",
     "@sendgrid/mail": "^8.1.0",
     "@sentry/hub": "^7.40.0",
     "@sentry/node": "^7.40.0",
@@ -119,11 +119,11 @@
     "typescript": "4.9.5"
   },
   "optionalDependencies": {
-    "@novu/ee-auth": "^0.24.2",
-    "@novu/ee-billing": "^0.24.2",
-    "@novu/ee-echo-api": "^0.24.2",
-    "@novu/ee-shared-services": "^0.24.2",
-    "@novu/ee-translation": "^0.24.2"
+    "@novu/ee-auth": "workspace:",
+    "@novu/ee-billing": "workspace:",
+    "@novu/ee-echo-api": "workspace:",
+    "@novu/ee-shared-services": "workspace:",
+    "@novu/ee-translation": "workspace:"
   },
   "lint-staged": {
     "*.{js,jsx,ts,tsx}": [

diff --git a/apps/inbound-mail/Dockerfile b/apps/inbound-mail/Dockerfile
@@ -4,7 +4,7 @@ RUN apk add g++ make py3-pip
 ENV NX_DAEMON=false
 
 RUN npm i pm2 -g
-RUN npm --no-update-notifier --no-fund --global install pnpm@8.9.0
+RUN npm --no-update-notifier --no-fund --global install pnpm@9.1.1
 RUN pnpm --version
 
 USER 1000

diff --git a/apps/inbound-mail/package.json b/apps/inbound-mail/package.json
@@ -19,8 +19,8 @@
     "test": "cross-env TS_NODE_COMPILER_OPTIONS='{\"strictNullChecks\": false}' TZ=UTC NODE_ENV=test E2E_RUNNER=true mocha --trace-warnings --timeout 10000 --require ts-node/register --exit --file e2e/setup.ts src/**/**/*.spec.ts"
   },
   "dependencies": {
-    "@novu/application-generic": "^0.24.2",
-    "@novu/shared": "^0.24.2",
+    "@novu/application-generic": "workspace:",
+    "@novu/shared": "workspace:",
     "@sentry/node": "^7.12.1",
     "bluebird": "^2.9.30",
     "dotenv": "^8.6.0",
@@ -39,7 +39,7 @@
     "winston": "^3.9.0"
   },
   "devDependencies": {
-    "@novu/testing": "^0.24.2",
+    "@novu/testing": "workspace:",
     "@types/chai": "^4.2.11",
     "@types/express": "^4.17.8",
     "@types/html-to-text": "^9.0.1",

diff --git a/apps/web/Dockerfile b/apps/web/Dockerfile
@@ -7,7 +7,7 @@ WORKDIR /usr/src/app
 
 
 RUN apk add --no-cache bash
-RUN npm install -g pnpm@8.9.0 --loglevel notice
+RUN npm install -g pnpm@9.1.1 --loglevel notice
 
 COPY .npmrc .
 COPY package.json .
@@ -37,7 +37,7 @@ RUN NX_DAEMON=false pnpm build:web
 FROM node:20-alpine
 
 RUN apk add --no-cache bash
-RUN npm install -g pnpm@8.9.0 http-server --loglevel notice
+RUN npm install -g pnpm@9.1.1 http-server --loglevel notice
 
 USER 1000
 WORKDIR /app

diff --git a/apps/web/package.json b/apps/web/package.json
@@ -59,11 +59,11 @@
     "@mantine/prism": "^5.7.1",
     "@mantine/spotlight": "^5.7.1",
     "@monaco-editor/react": "^4.6.0",
-    "@novu/design-system": "^0.24.2",
-    "@novu/notification-center": "^0.24.2",
-    "@novu/novui": "^0.0.1",
-    "@novu/shared": "^0.24.1",
-    "@novu/shared-web": "^0.24.1",
+    "@novu/design-system": "workspace:",
+    "@novu/notification-center": "workspace:",
+    "@novu/novui": "workspace:",
+    "@novu/shared": "workspace:",
+    "@novu/shared-web": "workspace:",
     "@rive-app/react-canvas": "^4.8.1",
     "@segment/analytics-next": "^1.48.0",
     "@sentry/react": "^7.40.0",
@@ -132,18 +132,18 @@
     "zod": "^3.22.4"
   },
   "optionalDependencies": {
-    "@novu/ee-billing-web": "^0.24.2",
-    "@novu/ee-echo-web": "^0.24.2",
-    "@novu/ee-translation-web": "^0.24.2"
+    "@novu/ee-billing-web": "workspace:",
+    "@novu/ee-echo-web": "workspace:",
+    "@novu/ee-translation-web": "workspace:"
   },
   "devDependencies": {
     "@babel/polyfill": "^7.12.1",
     "@babel/preset-env": "^7.23.2",
     "@babel/preset-react": "^7.13.13",
     "@babel/preset-typescript": "^7.13.0",
     "@babel/runtime": "^7.20.13",
-    "@novu/dal": "^0.24.2",
-    "@novu/testing": "^0.24.2",
+    "@novu/dal": "workspace:",
+    "@novu/testing": "workspace:",
     "@pandacss/dev": "^0.38.0",
     "@pandacss/studio": "^0.38.0",
     "@playwright/test": "^1.42.1",

diff --git a/apps/webhook/Dockerfile b/apps/webhook/Dockerfile
@@ -3,7 +3,7 @@ RUN apk add g++ make py3-pip
 ENV NX_DAEMON=false
 
 RUN npm i pm2 -g
-RUN npm --no-update-notifier --no-fund --global install pnpm@8.9.0
+RUN npm --no-update-notifier --no-fund --global install pnpm@9.1.1
 RUN pnpm --version
 
 USER 1000

diff --git a/apps/webhook/package.json b/apps/webhook/package.json
@@ -25,11 +25,11 @@
     "@nestjs/core": "^10.2.2",
     "@nestjs/platform-express": "^10.2.2",
     "@nestjs/terminus": "^10.0.1",
-    "@novu/application-generic": "^0.24.2",
-    "@novu/dal": "^0.24.2",
-    "@novu/shared": "^0.24.2",
-    "@novu/stateless": "^0.24.2",
-    "@novu/testing": "^0.24.2",
+    "@novu/application-generic": "workspace:",
+    "@novu/dal": "workspace:",
+    "@novu/shared": "workspace:",
+    "@novu/stateless": "workspace:",
+    "@novu/testing": "workspace:",
     "@sentry/node": "^7.66.0",
     "axios": "^1.6.2",
     "class-transformer": "^0.5.1",

diff --git a/apps/widget/Dockerfile b/apps/widget/Dockerfile
@@ -2,7 +2,7 @@ FROM node:20-alpine3.19
 ENV NX_DAEMON=false
 
 RUN apk add --no-cache bash g++ make py3-pip
-RUN npm install -g pnpm@8.9.0 --loglevel notice
+RUN npm install -g pnpm@9.1.1 --loglevel notice
 
 USER 1000
 WORKDIR /usr/src/app

diff --git a/apps/widget/package.json b/apps/widget/package.json
@@ -29,8 +29,8 @@
     "@emotion/styled": "^11.6.0",
     "@mantine/core": "4.2.12",
     "@mantine/hooks": "4.2.12",
-    "@novu/notification-center": "^0.24.2",
-    "@novu/shared": "^0.24.2",
+    "@novu/notification-center": "workspace:",
+    "@novu/shared": "workspace:",
     "antd": "^4.10.0",
     "babel-plugin-import": "^1.13.3",
     "chroma-js": "^2.4.2",
@@ -63,8 +63,8 @@
     "@emotion/react": "^11.7.1",
     "@emotion/styled": "^11.6.0",
     "@faker-js/faker": "^6.0.0",
-    "@novu/dal": "^0.24.2",
-    "@novu/testing": "^0.24.2",
+    "@novu/dal": "workspace:",
+    "@novu/testing": "workspace:",
     "@types/jest": "^29.5.0",
     "@types/node": "^12.0.0",
     "@types/react": "^17.0.0",

diff --git a/apps/worker/Dockerfile b/apps/worker/Dockerfile
@@ -3,7 +3,7 @@ RUN apk --update --no-cache add curl g++ make py3-pip
 ENV NX_DAEMON=false
 
 RUN npm i pm2 -g
-RUN npm --no-update-notifier --no-fund --global install pnpm@8.9.0
+RUN npm --no-update-notifier --no-fund --global install pnpm@9.1.1
 RUN pnpm --version
 
 USER 1000

diff --git a/apps/worker/package.json b/apps/worker/package.json
@@ -30,11 +30,11 @@
     "@nestjs/platform-express": "^10.2.2",
     "@nestjs/swagger": "^7.1.9",
     "@nestjs/terminus": "^10.0.1",
-    "@novu/application-generic": "^0.24.2",
-    "@novu/dal": "^0.24.2",
-    "@novu/shared": "^0.24.2",
-    "@novu/stateless": "^0.24.2",
-    "@novu/testing": "^0.24.2",
+    "@novu/application-generic": "workspace:",
+    "@novu/dal": "workspace:",
+    "@novu/shared": "workspace:",
+    "@novu/stateless": "workspace:",
+    "@novu/testing": "workspace:",
     "@sentry/node": "^7.40.0",
     "@sentry/tracing": "^7.40.0",
     "@types/newrelic": "^9.13.0",
@@ -84,11 +84,11 @@
     "typescript": "4.9.5"
   },
   "optionalDependencies": {
-    "@novu/ee-auth": "^0.24.2",
-    "@novu/ee-billing": "^0.24.2",
-    "@novu/ee-echo-worker": "^0.24.2",
-    "@novu/ee-shared-services": "^0.24.2",
-    "@novu/ee-translation": "^0.24.2"
+    "@novu/ee-auth": "workspace:",
+    "@novu/ee-billing": "workspace:",
+    "@novu/ee-echo-worker": "workspace:",
+    "@novu/ee-shared-services": "workspace:",
+    "@novu/ee-translation": "workspace:"
   },
   "lint-staged": {
     "*.{js,jsx,ts,tsx}": [

diff --git a/apps/ws/Dockerfile b/apps/ws/Dockerfile
@@ -2,7 +2,7 @@ FROM node:20-alpine3.19
 
 ENV NX_DAEMON=false
 
-RUN npm install -g pnpm@8.9.0 --loglevel notice
+RUN npm install -g pnpm@9.1.1 --loglevel notice
 RUN npm i pm2 -g
 RUN apk --no-cache add g++ make py3-pip
 

diff --git a/apps/ws/package.json b/apps/ws/package.json
@@ -29,10 +29,10 @@
     "@nestjs/swagger": "^7.1.9",
     "@nestjs/terminus": "^10.0.1",
     "@nestjs/websockets": "^10.2.2",
-    "@novu/application-generic": "^0.24.2",
-    "@novu/dal": "^0.24.2",
-    "@novu/shared": "^0.24.2",
-    "@novu/testing": "^0.24.2",
+    "@novu/application-generic": "workspace:",
+    "@novu/dal": "workspace:",
+    "@novu/shared": "workspace:",
+    "@novu/testing": "workspace:",
     "@sentry/node": "^7.30.0",
     "@socket.io/admin-ui": "^0.5.1",
     "@socket.io/redis-adapter": "^7.2.0",

diff --git a/enterprise/packages/auth/package.json b/enterprise/packages/auth/package.json
@@ -12,9 +12,9 @@
     "test-ee": "cross-env TS_NODE_COMPILER_OPTIONS='{\"strictNullChecks\": false}' TZ=UTC NODE_ENV=test E2E_RUNNER=true mocha --timeout 10000 --require ts-node/register --exit --file tests/setup.ts src/**/**/*.spec.ts"
   },
   "dependencies": {
-    "@novu/application-generic": "^0.24.2",
-    "@novu/dal": "^0.24.2",
-    "@novu/shared": "^0.24.2",
+    "@novu/application-generic": "workspace:",
+    "@novu/dal": "workspace:",
+    "@novu/shared": "workspace:",
     "passport-google-oauth": "^2.0.0"
   },
   "devDependencies": {