chore(dashboard): update create mock object from schema signature

novuhq · Dec 8, 2024 · 848fe15 · 848fe15
1 parent 1ba4b5a
commit 848fe15
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 12 deletions.
diff --git a/apps/api/src/app/workflows-v2/usecases/generate-preview/generate-preview.usecase.ts b/apps/api/src/app/workflows-v2/usecases/generate-preview/generate-preview.usecase.ts
@@ -134,13 +134,10 @@ export class GeneratePreviewUsecase {
       return finalPayload;
     }
 
-    const examplePayloadSchema = createMockObjectFromSchema(
-      {
-        type: 'object',
-        properties: { payload: workflow.payloadSchema },
-      },
-      true
-    );
+    const examplePayloadSchema = createMockObjectFromSchema({
+      type: 'object',
+      properties: { payload: workflow.payloadSchema },
+    });
 
     if (!examplePayloadSchema || Object.keys(examplePayloadSchema).length === 0) {
       return finalPayload;

diff --git a/apps/dashboard/src/components/workflow-editor/test-workflow/test-workflow-tabs.tsx b/apps/dashboard/src/components/workflow-editor/test-workflow/test-workflow-tabs.tsx
@@ -23,8 +23,8 @@ export const TestWorkflowTabs = ({ testData }: { testData: WorkflowTestDataRespo
   const { workflow } = useFetchWorkflow({
     workflowSlug,
   });
-  const to = useMemo(() => createMockObjectFromSchema(testData.to, true), [testData]);
-  const payload = useMemo(() => createMockObjectFromSchema(testData.payload, true), [testData]);
+  const to = useMemo(() => createMockObjectFromSchema(testData.to), [testData]);
+  const payload = useMemo(() => createMockObjectFromSchema(testData.payload), [testData]);
   const form = useForm<TestWorkflowFormType>({
     mode: 'onSubmit',
     resolver: zodResolver(buildDynamicFormSchema({ to: testData?.to ?? {} })),

diff --git a/packages/shared/src/utils/schema/create-mock-object-from-schema.ts b/packages/shared/src/utils/schema/create-mock-object-from-schema.ts
@@ -17,9 +17,9 @@ import { JSONSchemaDto } from '../../dto';
  */
 export function createMockObjectFromSchema(
   schema: JSONSchemaDto,
-  safe = true,
   path = '',
-  depth = 0
+  depth = 0,
+  safe = true
 ): Record<string, unknown> {
   const MAX_DEPTH = 10;
   if (depth >= MAX_DEPTH) {
@@ -48,7 +48,7 @@ export function createMockObjectFromSchema(
     if (definition.default) {
       acc[key] = definition.default;
     } else if (definition.type === 'object' && definition.properties) {
-      acc[key] = createMockObjectFromSchema(definition, safe, currentPath, depth + 1);
+      acc[key] = createMockObjectFromSchema(definition, currentPath, depth + 1);
     } else {
       acc[key] = `{{${currentPath}}}`;
     }