feat(api): add topic e2e

novuhq · Dec 9, 2024 · 5505702 · 5505702
1 parent 35d7783
commit 5505702
Show file tree

Hide file tree

Showing 5 changed files with 23 additions and 29 deletions.
diff --git a/apps/api/package.json b/apps/api/package.json
@@ -58,7 +58,7 @@
     "@sentry/tracing": "^7.40.0",
     "@types/newrelic": "^9.14.0",
     "@upstash/ratelimit": "^0.4.4",
-    "@novu/api": "^0.0.1-alpha.65",
+    "@novu/api": "^0.0.1-alpha.66",
     "axios": "^1.6.8",
     "liquidjs": "^10.13.1",
     "bcrypt": "^5.0.0",

diff --git a/apps/api/src/app/shared/helpers/e2e/sdk/e2e-sdk.helper.ts b/apps/api/src/app/shared/helpers/e2e/sdk/e2e-sdk.helper.ts
@@ -19,11 +19,10 @@ export function handleSdkError(error: unknown): { error: SDKError; parsedBody: a
   if (!isSDKError(error)) {
     throw new Error('Provided error is not an SDKError');
   }
-
   expect(error.name).to.equal('SDKError');
   expect(error.body).to.be.ok;
   expect(typeof error.body).to.be.eq('string');
-  const errorBody = JSON.parse(error.body);
+  const errorBody = error.body ? JSON.parse(error.body) : 'No Body';
 
   return { error, parsedBody: errorBody };
 }

diff --git a/apps/api/src/app/topics/topics.controller.ts b/apps/api/src/app/topics/topics.controller.ts
@@ -224,7 +224,7 @@ export class TopicsController {
   @HttpCode(HttpStatus.NO_CONTENT)
   @ApiOperation({ summary: 'Delete topic', description: 'Delete a topic by its topic key if it has no subscribers' })
   async deleteTopic(@UserSession() user: UserSessionData, @Param('topicKey') topicKey: TopicKey): Promise<void> {
-    return await this.deleteTopicUseCase.execute(
+    await this.deleteTopicUseCase.execute(
       DeleteTopicCommand.create({
         environmentId: user.environmentId,
         topicKey,

diff --git a/apps/api/src/app/topics/use-cases/get-topic-subscriber/get-topic-subscriber.use-case.ts b/apps/api/src/app/topics/use-cases/get-topic-subscriber/get-topic-subscriber.use-case.ts
@@ -4,13 +4,12 @@ import { TopicSubscribersEntity, TopicSubscribersRepository } from '@novu/dal';
 import { GetTopicSubscriberCommand } from './get-topic-subscriber.command';
 
 import { TopicSubscriberDto } from '../../dtos';
-import { ExternalSubscriberId } from '../../types';
 
 @Injectable()
 export class GetTopicSubscriberUseCase {
   constructor(private topicSubscribersRepository: TopicSubscribersRepository) {}
 
-  async execute(command: GetTopicSubscriberCommand) {
+  async execute(command: GetTopicSubscriberCommand): Promise<TopicSubscriberDto> {
     const topicSubscriber = await this.topicSubscribersRepository.findOneByTopicKeyAndExternalSubscriberId(
       command.environmentId,
       command.organizationId,
@@ -29,7 +28,7 @@ export class GetTopicSubscriberUseCase {
 
   private mapFromEntity(topicSubscriber: TopicSubscribersEntity): TopicSubscriberDto {
     return {
-      ...topicSubscriber,
+      externalSubscriberId: topicSubscriber.externalSubscriberId,
       topicKey: topicSubscriber.topicKey,
       _topicId: topicSubscriber._topicId,
       _organizationId: topicSubscriber._organizationId,

diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml