Merge branch 'next' into issue4245

novuhq · Oct 16, 2023 · 19e92b3 · 19e92b3
2 parents cf4ebeb + 65cda52
commit 19e92b3
Show file tree

Hide file tree

Showing 6 changed files with 203 additions and 493 deletions.
diff --git a/README.md b/README.md
@@ -149,9 +149,9 @@ Using the Novu API and admin panel, you can easily add a real-time notification
 Read more about how to add a notification center to your app with the Novu API [here](https://docs.novu.co/notification-center/getting-started)
 
 <p align="center">
-  <a href="https://docs.novu.co/notification-center/getting-started">React Component</a>
-  · <a href="https://docs.novu.co/notification-center/vue-component">Vue Component</a>
-  · <a href="https://github.com/novuhq/novu/tree/next/packages/notification-center-angular">Angular Component</a>
+  <a href="https://docs.novu.co/sdks/react">React Component</a>
+  · <a href="https://docs.novu.co/sdks/vue">Vue Component</a>
+  · <a href="https://docs.novu.co/sdks/angular">Angular Component</a>
   </p>
 
 </div>

diff --git a/apps/worker/src/app/workflow/services/active-jobs-metric.service.ts b/apps/worker/src/app/workflow/services/active-jobs-metric.service.ts
@@ -120,8 +120,12 @@ export class ActiveJobsMetricService {
   public async gracefulShutdown(): Promise<void> {
     Logger.log('Shutting the Active Jobs Metric service down', LOG_CONTEXT);
 
-    await this.activeJobsMetricQueueService.gracefulShutdown();
-    await this.activeJobsMetricWorkerService.gracefulShutdown();
+    if (this.activeJobsMetricQueueService) {
+      await this.activeJobsMetricQueueService.gracefulShutdown();
+    }
+    if (this.activeJobsMetricWorkerService) {
+      await this.activeJobsMetricWorkerService.gracefulShutdown();
+    }
 
     Logger.log('Shutting down the Active Jobs Metric service has finished', LOG_CONTEXT);
   }

diff --git a/apps/worker/src/app/workflow/services/completed-jobs-metric.service.ts b/apps/worker/src/app/workflow/services/completed-jobs-metric.service.ts
@@ -121,8 +121,12 @@ export class CompletedJobsMetricService {
   public async gracefulShutdown(): Promise<void> {
     Logger.log('Shutting the Completed Jobs Metric service down', LOG_CONTEXT);
 
-    await this.completedJobsMetricQueueService.gracefulShutdown();
-    await this.completedJobsMetricWorkerService.gracefulShutdown();
+    if (this.completedJobsMetricQueueService) {
+      await this.completedJobsMetricQueueService.gracefulShutdown();
+    }
+    if (this.completedJobsMetricWorkerService) {
+      await this.completedJobsMetricWorkerService.gracefulShutdown();
+    }
 
     Logger.log('Shutting down the Completed Jobs Metric service has finished', LOG_CONTEXT);
   }

diff --git a/libs/dal/package.json b/libs/dal/package.json
@@ -37,7 +37,6 @@
     "event-stream": "^4.0.1",
     "fs-extra": "^9.0.0",
     "googleapis": "^60.0.1",
-    "intercom-client": "^2.11.0",
     "jsonfile": "^6.0.1",
     "mongoose": "^7.5.0",
     "mongoose-delete": "^1.0.1",

diff --git a/libs/embed/package.json b/libs/embed/package.json
@@ -35,7 +35,6 @@
     "test:watch": "jest --coverage --watch",
     "test:prod": "pnpm lint && pnpm test -- --no-cache",
     "deploy-docs": "ts-node tools/gh-pages-publish",
-    "report-coverage": "cat ./coverage/lcov.info | coveralls",
     "commit": "git-cz",
     "semantic-release": "semantic-release",
     "semantic-release-prepare": "ts-node tools/semantic-release-prepare",
@@ -93,7 +92,6 @@
     "@types/node": "^14.14.16",
     "colors": "1.4.0",
     "concurrently": "^5.3.0",
-    "coveralls": "^3.0.2",
     "cross-env": "^5.2.0",
     "http-server": "^0.13.0",
     "husky": "^1.0.1",