Merge pull request #4393 from novuhq/add-nodemailer-types

fix: add missing nodemailer types
novuhq · Oct 4, 2023 · 185b0c8 · 185b0c8
2 parents a9d2d2a + 3001462
commit 185b0c8
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 1 deletion.
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/providers/nodemailer/src/lib/nodemailer.provider.spec.ts b/providers/nodemailer/src/lib/nodemailer.provider.spec.ts
@@ -44,6 +44,7 @@ describe('Config is set to secure=false but not user and password set', () => {
 
     expect(nodemailer.createTransport).toHaveBeenCalled();
     expect(nodemailer.createTransport).toHaveBeenCalledWith({
+      name: config.host,
       host: config.host,
       port: config.port,
       secure: config.secure,
@@ -95,6 +96,7 @@ describe('Config is set to secure=false (default; TLS used if server supports ST
 
     expect(nodemailer.createTransport).toHaveBeenCalled();
     expect(nodemailer.createTransport).toHaveBeenCalledWith({
+      name: mockConfig.host,
       host: mockConfig.host,
       port: mockConfig.port,
       secure: mockConfig.secure,

diff --git a/providers/outlook365/package.json b/providers/outlook365/package.json
@@ -38,6 +38,7 @@
   "devDependencies": {
     "@istanbuljs/nyc-config-typescript": "^1.0.1",
     "@types/jest": "^29.5.0",
+    "@types/nodemailer": "^6.4.11",
     "codecov": "^3.5.0",
     "cspell": "^4.1.0",
     "gh-pages": "^3.1.0",

diff --git a/providers/outlook365/src/lib/outlook365.provider.ts b/providers/outlook365/src/lib/outlook365.provider.ts
@@ -24,7 +24,7 @@ export class Outlook365Provider implements IEmailProvider {
       host: 'smtp.office365.com',
       port: 587,
       requireTLS: true,
-      connectionTImeout: 30000,
+      connectionTimeout: 30000,
       auth: {
         user: this.config.from,
         pass: this.config.password,