fix(actions): Pass secret as an input

More info at https://docs.github.com/en/enterprise-cloud@latest/actions/using-workflows/reusing-workflows\#using-inputs-and-secrets-in-a-reusable-workflow
novuhq · May 9, 2024 · 1699b45 · 1699b45
1 parent d472fca
commit 1699b45
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 1 deletion.
diff --git a/.github/actions/slack-notify-on-failure/action.yml b/.github/actions/slack-notify-on-failure/action.yml
@@ -1,4 +1,10 @@
 name: 'Notify Slack on workflow failure'
+
+inputs:
+  slackWebhookURL:
+    required: true
+    type: string
+
 runs:
   using: "composite"
   steps:
@@ -12,4 +18,4 @@ runs:
         notify_when: "failure"
         status: "failure"
       env:
-        SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL_ENG_FEED_GITHUB }}
+        SLACK_WEBHOOK_URL: ${{ input.slackWebhookURL }}
diff --git a/.github/workflows/reusable-api-e2e.yml b/.github/workflows/reusable-api-e2e.yml
@@ -113,3 +113,5 @@ jobs:
           cd apps/api && pnpm test
 
       - uses: ./.github/actions/slack-notify-on-failure
+        with:
+          slackWebhookURL: ${{ secrets.SLACK_WEBHOOK_URL_ENG_FEED_GITHUB }}
diff --git a/.github/workflows/reusable-web-e2e.yml b/.github/workflows/reusable-web-e2e.yml
@@ -186,6 +186,8 @@ jobs:
         retention-days: 14
 
     - uses: ./.github/actions/slack-notify-on-failure
+      with:
+        slackWebhookURL: ${{ secrets.SLACK_WEBHOOK_URL_ENG_FEED_GITHUB }}
 
   component_web:
     if: "!contains(github.event.head_commit.message, 'ci skip')"
@@ -232,3 +234,5 @@ jobs:
           path: apps/web/cypress/screenshots
 
       - uses: ./.github/actions/slack-notify-on-failure
+        with:
+          slackWebhookURL: ${{ secrets.SLACK_WEBHOOK_URL_ENG_FEED_GITHUB }}
diff --git a/.github/workflows/reusable-widget-e2e.yml b/.github/workflows/reusable-widget-e2e.yml
@@ -113,3 +113,5 @@ jobs:
           path: apps/widget/cypress/videos
 
       - uses: ./.github/actions/slack-notify-on-failure
+        with:
+          slackWebhookURL: ${{ secrets.SLACK_WEBHOOK_URL_ENG_FEED_GITHUB }}