Skip to content

Commit

Permalink
Merge pull request #4524 from novuhq/revert-4472-idempotency-impl
Browse files Browse the repository at this point in the history
Revert "feat: add idempotency interceptor"
  • Loading branch information
scopsy authored Oct 15, 2023
2 parents e4b3d8f + c5ff42d commit 0c478d0
Show file tree
Hide file tree
Showing 12 changed files with 3 additions and 509 deletions.
6 changes: 1 addition & 5 deletions .cspell.json
Original file line number Diff line number Diff line change
Expand Up @@ -510,11 +510,7 @@
"mediumdark",
"Docgen",
"clicksend",
"Clicksend",
"idempotency",
"IDEMPOTENCY",
"Idempotency",
"occured"
"Clicksend"
],
"flagWords": [],
"patterns": [
Expand Down
217 changes: 0 additions & 217 deletions apps/api/e2e/idempotency.e2e.ts

This file was deleted.

2 changes: 0 additions & 2 deletions apps/api/src/.env.development
Original file line number Diff line number Diff line change
Expand Up @@ -64,5 +64,3 @@ NOVU_SMS_INTEGRATION_SENDER=
INTERCOM_IDENTITY_VERIFICATION_SECRET_KEY=

LAUNCH_DARKLY_SDK_KEY=

API_IDEMPOTENCY_ENABLED=true
2 changes: 0 additions & 2 deletions apps/api/src/.env.production
Original file line number Diff line number Diff line change
Expand Up @@ -53,5 +53,3 @@ NOVU_SMS_INTEGRATION_SENDER=
INTERCOM_IDENTITY_VERIFICATION_SECRET_KEY=

LAUNCH_DARKLY_SDK_KEY=

API_IDEMPOTENCY_ENABLED=true
2 changes: 0 additions & 2 deletions apps/api/src/.env.test
Original file line number Diff line number Diff line change
Expand Up @@ -90,5 +90,3 @@ MAX_NOVU_INTEGRATION_SMS_REQUESTS=20
NOVU_SMS_INTEGRATION_ACCOUNT_SID=test
NOVU_SMS_INTEGRATION_TOKEN=test
NOVU_SMS_INTEGRATION_SENDER=1234567890

API_IDEMPOTENCY_ENABLED=true
8 changes: 1 addition & 7 deletions apps/api/src/app.module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ import { TopicsModule } from './app/topics/topics.module';
import { InboundParseModule } from './app/inbound-parse/inbound-parse.module';
import { BlueprintModule } from './app/blueprint/blueprint.module';
import { TenantModule } from './app/tenant/tenant.module';
import { IdempotencyInterceptor } from './app/shared/framework/idempotency.interceptor';

const enterpriseImports = (): Array<Type | DynamicModule | Promise<DynamicModule> | ForwardReference> => {
const modules: Array<Type | DynamicModule | Promise<DynamicModule> | ForwardReference> = [];
Expand Down Expand Up @@ -79,12 +78,7 @@ const enterpriseModules = enterpriseImports();

const modules = baseModules.concat(enterpriseModules);

const providers: Provider[] = [
{
provide: APP_INTERCEPTOR,
useClass: IdempotencyInterceptor,
},
];
const providers: Provider[] = [];

if (process.env.SENTRY_DSN) {
modules.push(RavenModule);
Expand Down
Loading

0 comments on commit 0c478d0

Please sign in to comment.