Skip to content

Commit

Permalink
Add Initial code owners for web and docker files (#5318)
Browse files Browse the repository at this point in the history
* Create CODEOWNERS file and update .cspell.json

Introduced a new CODEOWNERS file to manage project ownership and review process in Github. Also, updated the .cspell.json with additional entries. This enhancement allows for a more structured code review process and improves the spell check functionality in the project.

* Update .cspell.json and remove unnecessary word entries

Several word entries such as 'Tomer' and 'devs' are now removed from .cspell.json file. This adjustment simplifies the spell check functionality in the project by limiting the dictionary to only necessary words.

* The provided commit message does not match the changes indicated in the diff section. The correct commit message would be:

Add ownership for Dockerfile to novu-infra team

The novu-infra team has been assigned as the owner of Dockerfile in all directories. This change ensures relevant notifications and permissions to the novu-infra team regarding modifications to Dockerfile.

* Update CODEOWNERS file

The "@novuhq/novu-devs" line is now commented out, effectively removing the novu-devs as default reviewers for most changes. This change was made pending team consensus.

---------

Co-authored-by: Richard Fontein <[email protected]>
  • Loading branch information
Cliftonz and rifont authored Apr 25, 2024
1 parent 20ed2ac commit 00d5df1
Showing 1 changed file with 15 additions and 0 deletions.
15 changes: 15 additions & 0 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
# Reference: https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners#codeowners-syntax

# By default we assume that the novu-devs should review most changes
# Removed for now until consensus is made by the team
# @novuhq/novu-devs

# Except for the following exceptions
# Novu infra team ownership
.github @novuhq/novu-infra
.husky @novuhq/novu-infra
docker @novuhq/novu-infra
**/Dockerfile @novuhq/novu-infra

# Novu community team ownership
apps/web @novuhq/novu-web

0 comments on commit 00d5df1

Please sign in to comment.