Fix the issue reported in #34 #36
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rt of Frame' section appears before 'DQT' section in the header. notmasteryet#34
|
@yurydelendik Please review it. Thank you for great work of this repo! |
|
Thanks. I will see if I can move this patch to the PDF.js repo. |
loretoparisi
added a commit
to loretoparisi/dominant-colors-xmlhttprequest-example
that referenced
this pull request
Apr 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the issue that component.quantizationTable is sometimes undefined as reported in #34.
The root cause is that jpgjs expects SOF (Start of Frame) section to appear after DQT section in jpeg header, but it's not always the case for some jpg files. I updated the code so it works whether SOF appears after DQT or not.