Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated CODEOWNERS and MAINTAINERS files #6

Merged
merged 2 commits into from
Jan 25, 2024
Merged

Updated CODEOWNERS and MAINTAINERS files #6

merged 2 commits into from
Jan 25, 2024

Conversation

toddysm
Copy link
Contributor

@toddysm toddysm commented Jan 11, 2024

priteshbandi
priteshbandi approved these changes Jan 24, 2024
View reviewed changes
Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

NiazFK
NiazFK approved these changes Jan 24, 2024
View reviewed changes
Copy link

@NiazFK NiazFK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

SteveLasker
SteveLasker approved these changes Jan 24, 2024
View reviewed changes
Copy link

@SteveLasker SteveLasker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Two-Hearts
Two-Hearts approved these changes Jan 25, 2024
View reviewed changes
Copy link
Contributor

@Two-Hearts Two-Hearts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ef1051f) 88.27% compared to head (4ff04e3) 88.27%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main       #6   +/-   ##
=======================================
  Coverage   88.27%   88.27%           
=======================================
  Files           7        7           
  Lines         273      273           
=======================================
  Hits          241      241           
  Misses         27       27           
  Partials        5        5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@priteshbandi priteshbandi merged commit 29add9b into notaryproject:main Jan 25, 2024
7 checks passed
@priteshbandi priteshbandi mentioned this pull request Jan 29, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Two-Hearts Two-Hearts Two-Hearts approved these changes

@NiazFK NiazFK NiazFK approved these changes

@SteveLasker SteveLasker SteveLasker approved these changes

@priteshbandi priteshbandi priteshbandi approved these changes

@gokarnm gokarnm Awaiting requested review from gokarnm gokarnm is a code owner

@JeyJeyGao JeyJeyGao Awaiting requested review from JeyJeyGao JeyJeyGao is a code owner

@rgnote rgnote Awaiting requested review from rgnote rgnote is a code owner

@shizhMSFT shizhMSFT Awaiting requested review from shizhMSFT shizhMSFT is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@toddysm @codecov-commenter @priteshbandi @SteveLasker @NiazFK @Two-Hearts