fix: revocation response status code should be 200 #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Junjie Gao <[email protected]>
JeyJeyGao
requested review from
gokarnm,
NiazFK,
priteshbandi,
rgnote,
shizhMSFT,
toddysm,
Two-Hearts,
vaninrao10 and
yizha1
as code owners
Signed-off-by: Junjie Gao <[email protected]>
|
The CI failed, looks like this PR is waiting for #238 to be merged. |
priteshbandi
previously approved these changes
Oct 31, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #239 +/- ##
==========================================
+ Coverage 91.70% 91.81% +0.11%
==========================================
Files 30 30
Lines 2616 2616
==========================================
+ Hits 2399 2402 +3
+ Misses 165 163 -2
+ Partials 52 51 -1 ☔ View full report in Codecov by Sentry. |
JeyJeyGao
dismissed stale reviews from Two-Hearts, shizhMSFT, and priteshbandi
via
af09b29
Signed-off-by: Junjie Gao <[email protected]>
shizhMSFT
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corresponding spec change: notaryproject/specifications#319