fix: update

Signed-off-by: Junjie Gao <[email protected]>
notaryproject · Aug 20, 2024 · 291cdb7 · 291cdb7
1 parent b8fb823
commit 291cdb7
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/revocation/crl/cache/file.go b/revocation/crl/cache/file.go
@@ -115,11 +115,10 @@ func (c *FileCache) Set(ctx context.Context, uri string, bundle *Bundle) error {
 	if err != nil {
 		return err
 	}
-	defer tempFile.Close()
-
 	if err := saveTar(tempFile, bundle); err != nil {
 		return err
 	}
+	tempFile.Close()
 
 	// rename is atomic on UNIX-like platforms
 	return os.Rename(tempFile.Name(), filepath.Join(c.root, fileName(uri)))

diff --git a/revocation/crl/cache/file_test.go b/revocation/crl/cache/file_test.go
@@ -23,6 +23,7 @@ import (
 	"math/big"
 	"os"
 	"path/filepath"
+	"runtime"
 	"strings"
 	"testing"
 	"time"
@@ -92,6 +93,10 @@ func TestFileCache(t *testing.T) {
 func TestNewFileCache(t *testing.T) {
 	tempDir := t.TempDir()
 	t.Run("without permission to create cache directory", func(t *testing.T) {
+		if runtime.GOOS == "windows" {
+			t.Skip("skipping test on Windows")
+		}
+
 		if err := os.Chmod(tempDir, 0); err != nil {
 			t.Fatalf("failed to change permission: %v", err)
 		}