Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added plugin development security doc #270

Merged
merged 1 commit into from
Jun 13, 2023
Merged

added plugin development security doc #270

merged 1 commit into from
Jun 13, 2023

Conversation

zr-msft
Copy link
Collaborator

@zr-msft zr-msft commented Jun 2, 2023 •
edited
Loading

fixes #227
fixes #185

@netlify
Copy link

netlify bot commented Jun 2, 2023 •
edited
Loading

✅ Deploy Preview for notarydev ready!

Name Link
🔨 Latest commit 945052e
🔍 Latest deploy log https://app.netlify.com/sites/notarydev/deploys/647e12e62e43090008a56a25
😎 Deploy Preview https://deploy-preview-270--notarydev.netlify.app/docs/concepts/secure-plugin-development
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@zr-msft
Copy link
Collaborator Author

zr-msft commented Jun 2, 2023

@yizha1 @FeynmanZhou @shizhMSFT

This is a very early version of the doc. Can you please provide additional suggestions with details for anything else that should be included.

@shizhMSFT
Copy link
Contributor

Most best practices are actually covered by the plugin spec itself. It would be better to let the plugin developers to read the specs carefully.

FeynmanZhou
FeynmanZhou reviewed Jun 5, 2023
View reviewed changes
Copy link
Member

@FeynmanZhou FeynmanZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTAL

@zr-msft zr-msft mentioned this pull request Jun 5, 2023
Closed
@zr-msft
Copy link
Collaborator Author

zr-msft commented Jun 5, 2023

@shizhMSFT @FeynmanZhou thank you for the quick feedback!

I've incorporated your feedback into the PR.

PTAL

yizha1
yizha1 reviewed Jun 8, 2023
View reviewed changes
Copy link
Contributor

@yizha1 yizha1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. @zr-msft LTGM for first version. Just need Shiwei and Pritesh to confirm the text I quoted.

priteshbandi
priteshbandi approved these changes Jun 13, 2023
View reviewed changes
Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shizhMSFT
shizhMSFT approved these changes Jun 13, 2023
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

content/en/docs/concepts/secure-plugin-development.md Show resolved Hide resolved
yizha1
yizha1 approved these changes Jun 13, 2023
View reviewed changes
Copy link
Contributor

@yizha1 yizha1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @priteshbandi and @shizhMSFT to confirm it.

LGTM

@yizha1 yizha1 merged commit f76b905 into notaryproject:main Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FeynmanZhou FeynmanZhou FeynmanZhou left review comments

@yizha1 yizha1 yizha1 approved these changes

@shizhMSFT shizhMSFT shizhMSFT approved these changes

@priteshbandi priteshbandi priteshbandi approved these changes

@NiazFK NiazFK Awaiting requested review from NiazFK NiazFK is a code owner

@iamsamirzon iamsamirzon Awaiting requested review from iamsamirzon iamsamirzon is a code owner

@justincormack justincormack Awaiting requested review from justincormack

@SteveLasker SteveLasker Awaiting requested review from SteveLasker

@toddysm toddysm Awaiting requested review from toddysm toddysm is a code owner

@vaninrao10 vaninrao10 Awaiting requested review from vaninrao10 vaninrao10 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document security best practices for plugin development Document the security best practice
5 participants
@zr-msft @shizhMSFT @priteshbandi @FeynmanZhou @yizha1