Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back non-pubkey zap tags #1044

Closed

Conversation

staab
Copy link
Member

@staab staab commented Feb 13, 2024

Last May we removed lightning address support from zap splits, which broke Wavlake's implementation. Should we restore this behavior?

@jb55 @vitorpamplona @pablof7z

@staab
Copy link
Member Author

staab commented Feb 13, 2024

@joshr4 @blastshielddown what are your thoughts on this? Would it greatly matter to you to bring back zap splits so that clients could start to support wavlake's zap tags, or would you be willing to migrate to the new version?

@alexgleason
Copy link
Member

Related: benthecarman/zapple-pay-backend#11

It would make zap splits easier. But I don't think it's actually a good idea, but I don't think we should support two different ways.

@vitorpamplona
Copy link
Collaborator

vitorpamplona commented Feb 13, 2024

The main issue with the old way is that Clients can't identify who the owner of the lnaddress is in order to set expectations correctly and get the zapping user approval before moving forward.

In kind 1s, users either had to manually explain which lnaddress was owned by who in the .content or users simply wouldn't zap it. And when they did without knowing it was a split, many users got mad.

Since the change, I have had zero issues of this type.

@joshr4
Copy link

joshr4 commented Feb 13, 2024

Yeah we can migrate easily enough, especially since we don't depend on that original split functionality today.

We're definitely interested in any current/future split conversations as they develop, thats one reason we had chosen that old way at the time

@staab
Copy link
Member Author

staab commented Feb 13, 2024

Cool, I'll close this then.

@staab staab closed this Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants