Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added new weapons to DamageType enum #224

Open
wants to merge 3 commits into
base: 13.1
Choose a base branch
from
Open

Added new weapons to DamageType enum #224

wants to merge 3 commits into from

Conversation

Lufou
Copy link

@Lufou Lufou commented Sep 2, 2023

No description provided.

@Lufou Lufou changed the title Added FRMG0 to DamageType enum Added new weapons to DamageType enum Sep 2, 2023
ced777ric
ced777ric requested changes Sep 2, 2023
View reviewed changes
Copy link
Member

@ced777ric ced777ric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the reason for inserting the DamageType in the middle of the Enum?
This would cause issues with existing plugins by shifting the order of the Enum.

@Lufou Lufou requested a review from ced777ric September 2, 2023 17:16
SoNearSonar
SoNearSonar reviewed Sep 2, 2023
View reviewed changes
Copy link

@SoNearSonar SoNearSonar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SoNearSonar SoNearSonar SoNearSonar left review comments

@ced777ric ced777ric Awaiting requested review from ced777ric

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Lufou @ced777ric @SoNearSonar