-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standalone Mode (Beta) (1/3) #86
Merged
pmarkowsky
merged 23 commits into
northpolesec:main
from
pmarkowsky:plm/standalone-mode-swift
Dec 4, 2024
Merged
Standalone Mode (Beta) (1/3) #86
pmarkowsky
merged 23 commits into
northpolesec:main
from
pmarkowsky:plm/standalone-mode-swift
Dec 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmarkowsky
added
comp/santad
Issues or PRs related to the daemon
comp/gui
Issues or PRs related to the Santa GUI
labels
Oct 27, 2024
pmarkowsky
force-pushed
the
plm/standalone-mode-swift
branch
4 times, most recently
from
November 7, 2024 03:48
4689294
to
d2b045b
Compare
pmarkowsky
commented
Nov 7, 2024
mlw
requested changes
Nov 7, 2024
mlw
requested changes
Nov 10, 2024
pmarkowsky
force-pushed
the
plm/standalone-mode-swift
branch
2 times, most recently
from
November 25, 2024 04:01
dae864c
to
ed1a6a8
Compare
This was referenced Nov 26, 2024
Closed
pmarkowsky
added a commit
to northpolesec/protos
that referenced
this pull request
Nov 27, 2024
This PR does the following: - Adds a standalone mode to the ClientMode enum. - Adds a new event type to the EventUpload stage called an audit event It is part of the Standalone Mode work for northpolesec/santa#132 and is blocking northpolesec/santa#86
pmarkowsky
force-pushed
the
plm/standalone-mode-swift
branch
from
November 27, 2024 21:35
9737d34
to
feaa11a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nits
pmarkowsky
force-pushed
the
plm/standalone-mode-swift
branch
from
December 2, 2024 21:57
5e31175
to
74d28af
Compare
mlw
requested changes
Dec 3, 2024
russellhancox
requested changes
Dec 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These 4 changes go together to avoid blocking the main thread. I've tested them locally
russellhancox
approved these changes
Dec 4, 2024
When running in standalone mode TouchID can be used to approved binaries. If a binary is properly signed a SigningID rule is generated otherwise a SHA256 rule is generated. Note this lacks a GUI for browsing rules in the local rule db. Also adds localizable strings for Approve button.
Address review feedback. Make standalone mode only work for unknown blocks.
Co-authored-by: Russell Hancox <[email protected]> Signed-off-by: Pete Markowsky <[email protected]>
Co-authored-by: Russell Hancox <[email protected]> Signed-off-by: Pete Markowsky <[email protected]>
Co-authored-by: Russell Hancox <[email protected]> Signed-off-by: Pete Markowsky <[email protected]>
Co-authored-by: Russell Hancox <[email protected]> Signed-off-by: Pete Markowsky <[email protected]>
Co-authored-by: Russell Hancox <[email protected]> Signed-off-by: Pete Markowsky <[email protected]>
pmarkowsky
force-pushed
the
plm/standalone-mode-swift
branch
from
December 4, 2024 20:00
aacdd0e
to
fd6b11b
Compare
mlw
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates a new Santa operating mode -- standalone
This adds a new operating mode to Santa called standalone mode.
When running in standalone mode TouchID can be used to approved binaries. If a
binary is properly signed a SigningID rule is generated otherwise a SHA256 rule
is generated.
When using a sync service standalone mode won't override explicit block rules, but will allow a user to approve anything blocked by default.
Video demo-ing standlone.
Note
This lacks a GUI for browsing rules in the local rule db
This supersedes #5.
Also the sync protocol changes are saved for a future PR.
To Do
SNTEventAllowLocalSHA256
,SNTEventAllowLocalSigningID
sync_type
repeatable in sync protocol. (Future PR)