[DRAFT] Add codesigning information to the ProcessInfoLight message #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlw
force-pushed
the
add-cs-info-to-processinfolight
branch
from
08a4315 to
1cd43b7
Compare
|
|
|
@mlw any reason not to put this in 2025.1? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the
CodeSignaturemessage (proto) to theProcessInfoLightmessage (proto).Currently there are no good identifiers (except for path) when looking at a telemetry log to understand what the process might be. The
CodeSignaturemessage exists in the largerProcessInfomessage, but that is only used by EXEC and FAA events.Pros: Adding the SID and TID will make processes more recognizable. The cdhash will also help make queries easier.
Cons: It does add overhead small overhead to event sizes. Also, while using cdhash to look for execs would be easier to get more information about a given process (e.g. the hash), you'd still need to run sub queries looking for pid/pidver and parent pid/pidver to find the exact EXEC for a process (e.g. to see args).