Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update submodule to latest and update N2ST fct call with new prefix #582

Merged
merged 2 commits into from
Aug 15, 2024

Conversation

RedLeader962
Copy link
Collaborator

@RedLeader962 RedLeader962 commented Aug 14, 2024

Description

refactor: prefix functions with n2st namespace

  • Renamed functions to include the n2st namespace for consistency.
  • Updated script header and footer printing functions.
  • Aligned warning and error message functions for uniformity.
  • Ensured splash screen functions reflect the new naming convention.

build: update N2ST and NBS submodule to latest

  • Updated N2ST and NBS submodules to their latest versions for improved stability and feature set.

Checklist:

Code related

  • I have made corresponding changes to the documentation
    (i.e.: function, class, script header, README.md)
  • I have commented hard-to-understand code
  • I have added tests that prove my fix is effective or that my feature works
  • All tests pass locally with my changes
    (Check contributing_instructions.md for local testing procedure using libpointmatcher-build-system)

PR creation related

  • My pull request base ref branch is set to the develop branch
    (the build-system won't be triggered otherwise)
  • My pull request branch is up-to-date with the develop branch
    (the build-system will reject it otherwise)

PR description related

  • I have included a quick summary of the changes
  • I have indicated the related issue's id with # <issue-id> if changes are of type fix
  • I have included a high-level list of changes and their corresponding types
    (See commit_msg_reference.md for details)

- Renamed functions to include the n2st namespace for consistency
- Updated script header and footer printing functions
- Aligned warning and error message functions for uniformity
- Ensured splash screen functions reflect new naming convention
Copy link

sonarcloud bot commented Aug 14, 2024

@RedLeader962 RedLeader962 merged commit 057f73a into develop Aug 15, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant