Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: build-system side unstable compilation issue fix [NMO-402] #539

Conversation

RedLeader962
Copy link
Collaborator

@RedLeader962 RedLeader962 commented Nov 28, 2023

libpointmatcher-build-system related changes:

  • update the libpointmatcher cmake install flag following PR Fixes to CMake library management config generation #538 fix
    Note: we keept the CMAKE_INSTALL_PREFIX for the build-system cmake install
  • added test logic for LPM compilation cases:
    1. cmake install automatic path resolution,
    2. cmake install prefixed path,
    3. case where LPM is use directly,
    4. case where LPM is use as a library
  • fix the libpointmatcher dependencies-doc image path resolution logic
  • added note for futur references
  • several linting and file formating related cleanup

norlab-build-system related changes:

  • refactor environment variable prefix to match norlab-build-system lib
  • change the name for the call to repository version master branch current version from head to latest
  • fix the norlab-build-system path resolution in files from the lpm_utility_script.bash
  • lpm install script:
    • modified the github repository clone (or not) logic so that its repository agnostic
  • build matrix crawler:
    • refactor the freeze logic in
    • delete env var prefixed with FREEZE_

Other changes

  • added git codeowner file
  • added JetBrain IDEA run configuration

- added test logic for LPM compilation cases:
   - automatic path resolution,
   - prefixed path,
   - use lpm directly,
   - use lpm as a library
 - file formating
- refactor environment variable prefix to match norlab-build-system lib
- change the name for the call to repository version master branch current version from "head" to "latest"
- added development idea run configuration
- refactor environment variable prefix to match norlab-build-system lib
- change the name for the call to repository version master branch current version from "head" to "latest"
- fix the norlab-build-system path resolution in files from the `lpm_utility_script.bash`
…tem submodule [NMO-398]

- make the github repository clone or not logic repository agnostic
- refactor the freeze logic using `declare -ar`
- delete env var prefixed with FREEZE_
- linting
…norlab-build-system-submodule' into NMO-425-feat-prepare-libpointmatcher-build-system-beta-release

# Conflicts:
#	build_system/.env
#	build_system/.env.prompt
#	build_system/docker-compose.libpointmatcher.yaml
#	build_system/lpm_utility_script/lpm_bashrc_config.bash
#	build_system/nbs_execute_compose.bash
#	build_system/nbs_execute_compose_over_build_matrix.bash
#	build_system/ubuntu/Dockerfile.dependencies
#	build_system/ubuntu/Dockerfile.dependencies_doc
#	build_system/ubuntu/Dockerfile.libpointmatcher
#	build_system/ubuntu/Dockerfile.libpointmatcher_ci_PR
#	build_system/ubuntu/Dockerfile.libpointmatcher_ci_SITREP_matrix
…tem submodule [NMO-398]

- make the github repository clone or not logic repository agnostic
- refactor the freeze logic using `declare -ar`
- delete env var prefixed with FREEZE_
- linting
… container for norlab-build-system path resolution logic
@RedLeader962 RedLeader962 merged commit e571136 into norlab-ulaval:develop Dec 6, 2023
6 checks passed
@RedLeader962 RedLeader962 mentioned this pull request Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant