Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New DataPoints filter for descriptor augmentation #535

Merged
merged 9 commits into from
Nov 22, 2023

Conversation

boxanm
Copy link
Collaborator

@boxanm boxanm commented Nov 21, 2023

This DataPointFilter adds a new descriptor with a given name, dimension, and values to the point cloud on which it is applied. It can be used, for example, when a map-building algorithm requires the scans to have the same descriptor as the existing map.

@boxanm
Copy link
Collaborator Author

boxanm commented Nov 21, 2023

I'm putting a TODO here to implement Python bindings for the filter ❌

Copy link
Collaborator

@simonpierredeschenes simonpierredeschenes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, there is only one small comment to address

@boxanm boxanm merged commit 7870496 into develop Nov 22, 2023
4 of 5 checks passed
@boxanm boxanm deleted the AddDescriptorDataPointsFilter branch November 22, 2023 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants