Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new icon "successManualFilled" to ui icons #731

Merged
merged 4 commits into from
Dec 5, 2024

Conversation

gmacev
Copy link
Contributor

@gmacev gmacev commented Dec 3, 2024

What

  • What was done in this Pull Request

    • Add "successManualFilled" icon to the SVGIcon component and its story;
    • Updated the "statusSuccessDetailed" icon
  • Screenshots

image

Testing

  • Is this change covered by the unit tests?

  • Is this change covered by the integration tests?

  • Is this change covered by the automated acceptance tests? (if applicable)

Compatibility

  • Does this change maintain backward compatibility?

Add "successManualFilled" icon to the SVGIcon component and its story.
This enhances the icon set with a new visual representation for success.
@gmacev gmacev self-assigned this Dec 3, 2024
@gmacev gmacev requested a review from a team as a code owner December 3, 2024 11:14
@gmacev gmacev requested review from ievavizg and janosio December 3, 2024 11:14
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-731.du3gff836giqw.amplifyapp.com

@gmacev gmacev marked this pull request as draft December 3, 2024 14:08
…lity

Refactor SVG path data to use consistent formatting and improve readability. This change enhances maintainability and ensures uniformity across SVG definitions.

fix(ui.tsx): update SVG path data for successManualFilled icon

Update the SVG path data for the successManualFilled icon to correct
visual inaccuracies and improve the icon's appearance. This change
ensures the icon is rendered correctly and consistently across
different platforms and devices.
@gmacev gmacev marked this pull request as ready for review December 4, 2024 11:39
ievavizg
ievavizg previously approved these changes Dec 4, 2024
jedrasik
jedrasik previously approved these changes Dec 4, 2024
Copy link
Contributor

@jedrasik jedrasik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one comment to improve something. Please consider it 🙏

Copy link

sonarqubecloud bot commented Dec 4, 2024

@gmacev gmacev merged commit 2ede9e3 into master Dec 5, 2024
7 of 8 checks passed
@gmacev gmacev deleted the add-successManualFilled-icon branch December 5, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants