Add type="button" to Select Button (#128)

nordcloud · Jul 28, 2020 · 584810f · 584810f
1 parent f9995e1
commit 584810f
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 10 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@nordcloud/gnui",
-  "version": "0.4.18",
+  "version": "0.4.19",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",
   "repository": "git://github.com/nordcloud/gnui.git",

diff --git a/src/components/selectbutton/SelectButton.tsx b/src/components/selectbutton/SelectButton.tsx
@@ -103,17 +103,29 @@ export const SelectButton: FunctionComponent<SelectButtonProps> = ({
   id = "",
   onClick,
   ...props
-}) => <li><button value={value} name={name} className={isActive ? "active" : ""} {...props} onClick={() => onClick(value)}>
-  {labelText}
-</button></li>;
+}) => (
+  <li>
+    <button
+      type="button"
+      value={value}
+      name={name}
+      className={isActive ? "active" : ""}
+      {...props}
+      onClick={() => onClick(value)}
+    >
+      {labelText}
+    </button>
+  </li>
+);
 
-export const MultipleSelect: FunctionComponent<SelectButtonListProps> = ({ 
+export const MultipleSelect: FunctionComponent<SelectButtonListProps> = ({
   status,
   children,
-  size
+  size,
 }) => {
   return (
-  <StyledSelectButtons status={status} size={size}>
-    {children}
-  </StyledSelectButtons>
-)};
+    <StyledSelectButtons status={status} size={size}>
+      {children}
+    </StyledSelectButtons>
+  );
+};