Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Local images #101

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Local images #101

wants to merge 4 commits into from

Conversation

rfair404
Copy link

@rfair404 rfair404 commented Jun 8, 2019 •
edited
Loading

@norcross as promised, find a "working" POC that replaces "remote" images with one that is locally hosted.

Features:

  • Adds lib/img/airplane.svg image.
  • Replaces "featured images" urls with the locally hosted image.
  • Replaces avatars with locally hosted image.
  • Replaces images found in the_content with the locally hosted image.

Notes: Before considering merging this, need to replace the airplane.svg an image with one that is properly licensed for distribution in accordance with this plugin's license.

norcross
norcross reviewed Jun 11, 2019
View reviewed changes
Copy link
Owner

@norcross norcross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rfair404 I'm working through getting this integrated. I'm likely going to abstract the function that checks whether or not any remote images exist.

@rfair404
Copy link
Author

@norcross sounds good. let me know if there is anything I can do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@norcross norcross norcross left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rfair404 @norcross