add Client method returning a stream of rows #40
+118
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nooberfsh
requested changes
Apr 16, 2024
Comment on lines
+394
to
+409
| struct MyStream<'a, T: Presto + 'static> { | ||
| inner: QueryInternal<'a, T>, | ||
| phantom: std::marker::PhantomData<T>, | ||
| } | ||
|
|
||
| enum QueryInternal<'a, T: Presto + 'static> { | ||
| Query { | ||
| sql: String, | ||
| client: &'a Client, | ||
| }, | ||
| Next { | ||
| already: Vec<T>, | ||
| next: Option<String>, | ||
| client: &'a Client, | ||
| }, | ||
| } |
There was a problem hiding this comment.
Can we merge MyStream and QueryInternal into something like QueryStream.
I can't see why a wrapper is necessary.
| match self.inner { | ||
| QueryInternal::Query { sql, client } => { | ||
| let res = client.get_retry::<T>(sql).await?; | ||
| let next = res.next_uri.clone(); |
| ))) | ||
| } else if let Some(url) = next { | ||
| let res = client.get_next_retry::<T>(&url).await?; | ||
| let next = res.next_uri.clone(); |
Comment on lines
+527
to
+533
| ) -> impl futures::stream::Stream<Item = Result<T>> + std::marker::Unpin + '_ { | ||
| let stream = MyStream { | ||
| inner: QueryInternal::Query { sql, client: self }, | ||
| phantom: std::marker::PhantomData, | ||
| }; | ||
| Box::pin(futures::stream::try_unfold(stream, MyStream::next_and_self)) | ||
| } |
There was a problem hiding this comment.
I think we should remove std::marker::Unpin on the return type and let user decide which pin strategy to use, e.g. pin! macro,Box::pin.
|
Hi, thanks for the contribution. I have left some comments, please take a look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a convenience so users can just iterate over a stream of rows. It also opens up the possibility of using
TryStreamcombinators, although honestly I haven't found those all that useful.