-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
trouble with vte.h #125
Comments
for the test builds by github workflows, I had to change the header statements for both ubuntu and fedora builds. |
There is a CMake-rule for vte: Available names are: libvte, vte and vte-2.91. What is this package vte-0.0? |
on fedora the available packages are:
the header files are installed into without 7f7a4b6 I was unable to compile on either fedora nor ubuntu. |
OMG, vte-0.28 is 11 years old. Why are you using it in 2022? Please show the output for this commands: Anyway version 0.28 should not be found. Minimum version in CMakeLists.txt is set to 0.46. |
for the github workflow tests, I changed the order to: pkg-config --list-all|grep vte
pkg-config --modversion vte-2.91
pkg-config --modversion vte291
pkg-config --modversion libvte
pkg-config --modversion vte ubuntu from github workflow vte-2.91 vte - VTE widget for GTK+ 3.0
0.68.0
Package vte2[9](https://github.com/SwissalpS/termit/actions/runs/3073685051/jobs/4965975010#step:9:10)1 was not found in the pkg-config search path.
Perhaps you should add the directory containing `vte291.pc'
to the PKG_CONFIG_PATH environment variable
No package 'vte291' found fedora from github workflow vte-2.91 vte - VTE widget for GTK+ 3.0
0.68.0
Package vte2[9](https://github.com/SwissalpS/termit/actions/runs/3073685051/jobs/4965975053#step:9:10)1 was not found in the pkg-config search path.
Perhaps you should add the directory containing `vte291.pc'
to the PKG_CONFIG_PATH environment variable
Package 'vte291', required by 'virtual:world', not found fedora on my desktop $ pkg-config --list-all|grep vte
vte vte - Vte terminal widget.
vte-2.91 vte - VTE widget for GTK+ 3.0
$ pkg-config --modversion vte
0.28.2
$ pkg-config --modversion vte291
Package vte291 was not found in the pkg-config search path.
Perhaps you should add the directory containing `vte291.pc'
to the PKG_CONFIG_PATH environment variable
Package 'vte291', required by 'virtual:world', not found
$ pkg-config --modversion libvte
Package libvte was not found in the pkg-config search path.
Perhaps you should add the directory containing `libvte.pc'
to the PKG_CONFIG_PATH environment variable
Package 'libvte', required by 'virtual:world', not found
$ pkg-config --modversion vte-2.91
0.68.0 |
Remove this package and all troubles with "include"-s should be gone. |
I improved the workflow output and made two branches:
Output of vteDump.sh on ubuntu:
fedora:
workflow log of AA variant
|
for fedora please show the output for |
|
According to proper include -I/usr/include/vte-2.91 and the presence of /usr/include/vte-2.91/vte the only remaining reason can be the content of this directory. Next time please build termit with verbose logs: |
test workflow log (with VERBOSE=0) contents of /usr/include/vte-2.91/vte:
|
Reproduced: https://oss.cipunited.com/ci/job/ciBuilds/job/termit/27/execution/node/47/log/ Lines 45 to 51 in 41978d9
CMake doc here: https://cmake.org/cmake/help/v3.24/module/FindPkgConfig.html -SET(TERMIT_CFLAGS "-I${LUA_INCLUDE_DIR}")
+SET(TERMIT_CFLAGS "") With this patch, built successfully on Arch Linux (mips64r6el, QEMU user): https://oss.cipunited.com/ci/job/ciBuilds/job/termit/42/execution/node/57/log/ Also built successfully on Arch Linux and Debian sid (both x86_64) in my local tests. This is a weird issue. Let's do a deep dive. What makes Arch Linux (, Fedora and Ubuntu, according to #125 (comment)) behave differently from Debian sid? Why Debian sid is not affected by the mistake? This is an interesting story. On Arch Linux, we see
However,
Thus, on Debian sid, nothing is missing. The coincidence lasted for 14 years! build envArch Linux (x86_64)
Debian sid (x86_64)
|
Luke, is everything fine? |
I have two versions of vte installed, 0.66.2 (vte-0.0) and 2.91 (vte-2.91).
cmake finds 0.66.2 but build (make) aborts with error "can't find vte/vte.h"
when I edit termit.c and .h to include vte-0.0/vte/vte.h, then there are missing commands.
When I edit to include vte-2.91/vte/vte.h I was able to build termit.
The text was updated successfully, but these errors were encountered: