Skip to content

Commit

Permalink
docs: add documentation about 1.0.0 yarn changes (#959)
Browse files Browse the repository at this point in the history
[skip ci]
  • Loading branch information
nolanlawson authored Feb 10, 2019
1 parent 37c85ec commit 734857d
Show file tree
Hide file tree
Showing 3 changed files with 23 additions and 4 deletions.
17 changes: 17 additions & 0 deletions BREAKING_CHANGES.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
# Breaking changes

This document contains a list of _breaking changes_ for Pinafore. For a full changelog, see [the GitHub release page](https://github.com/nolanlawson/pinafore/releases).

## 1.0.0

**Breaking change:** This version [switches Pinafore from npm to yarn](https://github.com/nolanlawson/pinafore/pull/927). Those who self-host Pinafore will need to make the following changes:

1. [Install yarn](https://yarnpkg.com/en/docs/install) if you haven't already.
2. Instead of `npm install`, run `yarn --pure-lockfile`.

This change fixes [a functional bug in Webpack](https://github.com/nolanlawson/pinafore/pull/926). If you use npm instead of yarn, Pinafore may not build correctly.

### Notes:

- Using `yarn start` instead of `npm start` should not make a difference.
- Those using Docker shouldn't need to change anything.
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ RUN npm i yarn -g

# Install Pinafore
RUN yarn --pure-lockfile
RUN yarn run build
RUN yarn build

# Expose port 4002
EXPOSE 4002
Expand Down
8 changes: 5 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -56,9 +56,9 @@ Pinafore requires [Node.js](https://nodejs.org/en/) v8+ and [Yarn](https://yarnp

To build Pinafore for production:

yarn
yarn run build
PORT=4002 npm start
yarn --pure-lockfile
yarn build
PORT=4002 yarn start

### Docker

Expand Down Expand Up @@ -96,6 +96,8 @@ how to run Pinafore in dev mode and run tests.

For a changelog, see the [GitHub releases](http://github.com/nolanlawson/pinafore/releases/).

For a list of breaking changes, see [https://github.com/nolanlawson/pinafore/blob/master/BREAKING_CHANGES.md](BREAKING_CHANGES.md).

## What's with the name?

Pinafore is named after the [Gilbert and Sullivan play](https://en.wikipedia.org/wiki/Hms_pinafore). The [soundtrack](https://www.allmusic.com/album/gilbert-sullivan-hms-pinafore-1949-mw0001830483) is very good.

0 comments on commit 734857d

Please sign in to comment.