chore: bump JS linting packages

noir-lang · Nov 8, 2024 · a42f183 · a42f183
1 parent b74b4ea
commit a42f183
Show file tree

Hide file tree

Showing 18 changed files with 1,400 additions and 934 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -21,4 +21,12 @@ module.exports = {
     ],
     'prettier/prettier': 'error',
   },
+  overrides: [
+    {
+      files: ['*.test.ts'],
+      rules: {
+        '@typescript-eslint/no-unused-expressions': 'off',
+      },
+    },
+  ],
 };
diff --git a/acvm-repo/acvm_js/.eslintignore b/acvm-repo/acvm_js/.eslintignore
@@ -1,2 +1,4 @@
 node_modules
-pkg
+pkg
+nodejs
+web
diff --git a/acvm-repo/acvm_js/.eslintrc.js b/acvm-repo/acvm_js/.eslintrc.js
@@ -1,3 +1,3 @@
 module.exports = {
-  extends: ["../../.eslintrc.js"],
+  extends: ['../../.eslintrc.js'],
 };
diff --git a/acvm-repo/acvm_js/package.json b/acvm-repo/acvm_js/package.json
@@ -31,7 +31,7 @@
     "build": "bash ./build.sh",
     "test": "env TS_NODE_COMPILER_OPTIONS='{\"module\": \"commonjs\" }' mocha",
     "test:browser": "web-test-runner",
-    "lint": "NODE_NO_WARNINGS=1 eslint . --ext .ts --ignore-path ./.eslintignore  --max-warnings 0",
+    "lint": "NODE_NO_WARNINGS=1 ESLINT_USE_FLAT_CONFIG=false eslint . --ext .ts --ignore-path ./.eslintignore  --max-warnings 0",
     "publish": "echo 📡 publishing `$npm_package_name` && yarn npm publish",
     "nightly:version": "jq --arg new_version \"-$(git rev-parse --short HEAD)$1\" '.version = .version + $new_version' package.json > package-tmp.json && mv package-tmp.json package.json",
     "clean": "chmod u+w web nodejs || true && rm -rf web nodejs"
@@ -42,10 +42,10 @@
     "@web/test-runner": "^0.18.1",
     "@web/test-runner-playwright": "^0.11.0",
     "chai": "^4.4.1",
-    "eslint": "^8.57.0",
-    "eslint-plugin-prettier": "^5.1.3",
+    "eslint": "^9.14.0",
+    "eslint-plugin-prettier": "^5.2.1",
     "mocha": "^10.2.0",
-    "prettier": "3.2.5",
+    "prettier": "3.3.3",
     "ts-node": "^10.9.1",
     "typescript": "^5.4.2"
   }

diff --git a/acvm-repo/acvm_js/test/node/build_info.test.ts b/acvm-repo/acvm_js/test/node/build_info.test.ts
@@ -8,7 +8,7 @@ it('returns the correct build info', () => {
 
   try {
     revision = child_process.execSync('git rev-parse HEAD').toString().trim();
-  } catch (error) {
+  } catch (_error) {
     console.log('Failed to get revision, skipping test.');
     return;
   }

diff --git a/compiler/integration-tests/package.json b/compiler/integration-tests/package.json
@@ -10,7 +10,7 @@
     "test:browser": "web-test-runner",
     "test:integration:browser": "web-test-runner test/browser/**/*.test.ts",
     "test:integration:browser:watch": "web-test-runner test/browser/**/*.test.ts --watch",
-    "lint": "NODE_NO_WARNINGS=1 eslint . --ext .ts --ignore-path ./.eslintignore  --max-warnings 0"
+    "lint": "NODE_NO_WARNINGS=1 ESLINT_USE_FLAT_CONFIG=false eslint . --ext .ts --ignore-path ./.eslintignore  --max-warnings 0"
   },
   "dependencies": {
     "@aztec/bb.js": "0.61.0",
@@ -22,11 +22,11 @@
     "@web/dev-server-import-maps": "^0.2.0",
     "@web/test-runner": "^0.18.1",
     "@web/test-runner-playwright": "^0.11.0",
-    "eslint": "^8.57.0",
-    "eslint-plugin-prettier": "^5.1.3",
+    "eslint": "^9.14.0",
+    "eslint-plugin-prettier": "^5.2.1",
     "ethers": "^6.7.1",
     "hardhat": "^2.22.6",
-    "prettier": "3.2.5",
+    "prettier": "3.3.3",
     "smol-toml": "^1.1.2",
     "toml": "^3.0.0",
     "tslog": "^4.9.2"

diff --git a/compiler/wasm/package.json b/compiler/wasm/package.json
@@ -39,14 +39,14 @@
     "clean": "rm -rf ./build ./target ./dist public/fixtures/simple/target public/fixtures/with-deps/target",
     "nightly:version": "jq --arg new_version \"-$(git rev-parse --short HEAD)$1\" '.version = .version + $new_version' package.json > package-tmp.json && mv package-tmp.json package.json",
     "publish": "echo 📡 publishing `$npm_package_name` && yarn npm publish",
-    "lint": "NODE_NO_WARNINGS=1 eslint . --ext .ts --ignore-path ./.eslintignore  --max-warnings 0"
+    "lint": "NODE_NO_WARNINGS=1 ESLINT_USE_FLAT_CONFIG=false eslint . --ext .ts --ignore-path ./.eslintignore  --max-warnings 0"
   },
   "devDependencies": {
     "@esm-bundle/chai": "^4.3.4-fix.0",
     "@ltd/j-toml": "^1.38.0",
     "@types/adm-zip": "^0.5.0",
     "@types/chai": "^4",
-    "@types/mocha": "^10.0.6",
+    "@types/mocha": "^10.0.9",
     "@types/mocha-each": "^2",
     "@types/node": "^20.10.5",
     "@types/pako": "^2",
@@ -62,14 +62,14 @@
     "browserify-fs": "^1.0.0",
     "chai": "^4.4.1",
     "copy-webpack-plugin": "^12.0.2",
-    "eslint": "^8.57.0",
-    "eslint-plugin-prettier": "^5.1.3",
+    "eslint": "^9.14.0",
+    "eslint-plugin-prettier": "^5.2.1",
     "html-webpack-plugin": "^5.6.0",
     "memfs": "^4.6.0",
     "mocha": "^10.2.0",
     "mocha-each": "^2.0.1",
     "path-browserify": "^1.0.1",
-    "prettier": "3.2.5",
+    "prettier": "3.3.3",
     "process": "^0.11.10",
     "readable-stream": "^4.4.2",
     "sinon": "^17.0.1",

diff --git a/compiler/wasm/src/noir/noir-wasm-compiler.ts b/compiler/wasm/src/noir/noir-wasm-compiler.ts
@@ -182,7 +182,7 @@ export class NoirWasmCompiler {
     try {
       const libFile = this.#dependencyManager.findFile(path);
       return await this.#fm.readFile(libFile ?? path, 'utf-8');
-    } catch (err) {
+    } catch (_err) {
       return '';
     }
   }

diff --git a/compiler/wasm/src/noir/package.ts b/compiler/wasm/src/noir/package.ts
@@ -28,7 +28,6 @@ export class Package {
   #packagePath: string;
   #srcPath: string;
   #config: PackageConfig;
-  #version: string | null = null;
 
   public constructor(path: string, srcDir: string, config: PackageConfig) {
     this.#packagePath = path;

diff --git a/docs/package.json b/docs/package.json
@@ -34,10 +34,10 @@
     "@docusaurus/module-type-aliases": "^3.5.2",
     "@docusaurus/tsconfig": "^3.5.2",
     "@docusaurus/types": "^3.5.2",
-    "@types/prettier": "^3",
+    "@types/prettier": "^3.0.0",
     "docusaurus-plugin-typedoc": "1.0.0-next.18",
-    "eslint-plugin-prettier": "^5.1.3",
-    "prettier": "3.2.5",
+    "eslint-plugin-prettier": "^5.2.1",
+    "prettier": "3.3.3",
     "serve": "^14.2.1",
     "ts-node": "^10.9.1",
     "typedoc": "^0.25.0",

diff --git a/package.json b/package.json
@@ -26,14 +26,14 @@
     "publish:all": "yarn install && yarn workspaces foreach run publish"
   },
   "devDependencies": {
-    "@typescript-eslint/eslint-plugin": "^6.7.3",
-    "@typescript-eslint/parser": "^6.7.3",
+    "@typescript-eslint/eslint-plugin": "^8.13.0",
+    "@typescript-eslint/parser": "^8.13.0",
     "chai": "^4.4.1",
     "cspell": "^8.3.2",
-    "eslint": "^8.57.0",
-    "eslint-plugin-prettier": "^5.1.3",
+    "eslint": "^9.14.0",
+    "eslint-plugin-prettier": "^5.2.1",
     "mocha": "^10.2.0",
-    "prettier": "3.2.5",
+    "prettier": "3.3.3",
     "ts-node": "^10.9.1",
     "typescript": "^5.4.2"
   },

diff --git a/tooling/noir_codegen/package.json b/tooling/noir_codegen/package.json
@@ -40,22 +40,22 @@
     "test:clean": "rm -rf ./test/codegen ./test/test_lib/export",
     "prettier": "prettier 'src/**/*.ts'",
     "prettier:fix": "prettier --write 'src/**/*.ts' 'test/**/*.ts'",
-    "lint": "NODE_NO_WARNINGS=1 eslint . --ext .ts --ignore-path ./.eslintignore  --max-warnings 0",
+    "lint": "NODE_NO_WARNINGS=1 ESLINT_USE_FLAT_CONFIG=false eslint . --ext .ts --ignore-path ./.eslintignore  --max-warnings 0",
     "nightly:version": "jq --arg new_version \"-$(git rev-parse --short HEAD)$1\" '.version = .version + $new_version' package.json > package-tmp.json && mv package-tmp.json package.json",
     "publish": "echo 📡 publishing `$npm_package_name` && yarn npm publish",
     "clean": "rm -rf ./lib"
   },
   "devDependencies": {
     "@noir-lang/noir_js": "workspace:*",
     "@types/chai": "^4",
-    "@types/mocha": "^10.0.1",
+    "@types/mocha": "^10.0.9",
     "@types/node": "^20.6.2",
-    "@types/prettier": "^3",
+    "@types/prettier": "^3.0.0",
     "chai": "^4.4.1",
-    "eslint": "^8.57.0",
-    "eslint-plugin-prettier": "^5.1.3",
+    "eslint": "^9.14.0",
+    "eslint-plugin-prettier": "^5.2.1",
     "mocha": "^10.2.0",
-    "prettier": "3.2.5",
+    "prettier": "3.3.3",
     "ts-node": "^10.9.1",
     "tsx": "^4.6.2",
     "typescript": "^5.4.2"

diff --git a/tooling/noir_js/package.json b/tooling/noir_js/package.json
@@ -43,24 +43,24 @@
     "test:node:cjs": "mocha --timeout 25000 --exit --config ./.mocharc.cjs.json",
     "prettier": "prettier 'src/**/*.ts'",
     "prettier:fix": "prettier --write 'src/**/*.ts' 'test/**/*.ts'",
-    "lint": "NODE_NO_WARNINGS=1 eslint . --ext .ts --ignore-path ./.eslintignore  --max-warnings 0",
+    "lint": "NODE_NO_WARNINGS=1 ESLINT_USE_FLAT_CONFIG=false eslint . --ext .ts --ignore-path ./.eslintignore  --max-warnings 0",
     "nightly:version": "jq --arg new_version \"-$(git rev-parse --short HEAD)$1\" '.version = .version + $new_version' package.json > package-tmp.json && mv package-tmp.json package.json",
     "publish": "echo 📡 publishing `$npm_package_name` && yarn npm publish",
     "clean": "rm -rf ./lib"
   },
   "devDependencies": {
     "@types/chai": "^4",
-    "@types/mocha": "^10.0.1",
+    "@types/mocha": "^10.0.9",
     "@types/node": "^20.6.2",
-    "@types/prettier": "^3",
+    "@types/prettier": "^3.0.0",
     "chai": "^4.4.1",
-    "eslint": "^8.57.0",
-    "eslint-plugin-prettier": "^5.1.3",
+    "eslint": "^9.14.0",
+    "eslint-plugin-prettier": "^5.2.1",
     "mocha": "^10.2.0",
-    "prettier": "3.2.5",
+    "prettier": "3.3.3",
     "ts-node": "^10.9.1",
     "tsc-multi": "^1.1.0",
-    "tsx": "^4.6.2",
-    "typescript": "^5.4.2"
+    "tsx": "^4.19.2",
+    "typescript": "^5.6.3"
   }
 }
diff --git a/tooling/noir_js/test/node/smoke.test.ts b/tooling/noir_js/test/node/smoke.test.ts
@@ -51,7 +51,7 @@ it('0x prefixed string input for inputs will throw', async () => {
   try {
     await new Noir(assert_lt_program).execute(inputsHexPrefix);
     expect.fail('Expected generatedWitness to throw, due to inputs being prefixed with 0x. Currently not supported');
-  } catch (error) {
+  } catch (_error) {
     // Successfully errored due to 0x not being supported. Update this test once/if we choose
     // to support 0x prefixed inputs.
   }

diff --git a/tooling/noir_js_types/.eslintignore b/tooling/noir_js_types/.eslintignore
@@ -1 +1,2 @@
 node_modules
+lib
diff --git a/tooling/noir_js_types/package.json b/tooling/noir_js_types/package.json
@@ -28,7 +28,7 @@
     "build": "yarn run build:cjs && yarn run build:esm",
     "nightly:version": "jq --arg new_version \"-$(git rev-parse --short HEAD)$1\" '.version = .version + $new_version' package.json > package-tmp.json && mv package-tmp.json package.json",
     "publish": "echo 📡 publishing `$npm_package_name` && yarn npm publish",
-    "lint": "NODE_NO_WARNINGS=1 eslint . --ext .ts --ignore-path ./.eslintignore  --max-warnings 0",
+    "lint": "NODE_NO_WARNINGS=1 ESLINT_USE_FLAT_CONFIG=false eslint . --ext .ts --ignore-path ./.eslintignore  --max-warnings 0",
     "clean": "rm -rf ./lib"
   },
   "exports": {
@@ -39,10 +39,10 @@
     }
   },
   "devDependencies": {
-    "@types/prettier": "^3",
-    "eslint": "^8.57.0",
-    "eslint-plugin-prettier": "^5.1.3",
-    "prettier": "3.2.5",
+    "@types/prettier": "^3.0.0",
+    "eslint": "^9.14.0",
+    "eslint-plugin-prettier": "^5.2.1",
+    "prettier": "3.3.3",
     "typescript": "^5.4.2"
   }
 }
diff --git a/tooling/noirc_abi_wasm/package.json b/tooling/noirc_abi_wasm/package.json
@@ -33,7 +33,7 @@
     "clean": "chmod u+w web nodejs || true && rm -rf ./nodejs ./web ./target ./result",
     "nightly:version": "jq --arg new_version \"-$(git rev-parse --short HEAD)$1\" '.version = .version + $new_version' package.json > package-tmp.json && mv package-tmp.json package.json",
     "publish": "echo 📡 publishing `$npm_package_name` && yarn npm publish",
-    "lint": "NODE_NO_WARNINGS=1 eslint . --ext .ts --ignore-path ./.eslintignore  --max-warnings 0"
+    "lint": "NODE_NO_WARNINGS=1 ESLINT_USE_FLAT_CONFIG=false eslint . --ext .ts --ignore-path ./.eslintignore  --max-warnings 0"
   },
   "dependencies": {
     "@noir-lang/types": "workspace:*"
@@ -43,7 +43,7 @@
     "@web/dev-server-esbuild": "^0.3.6",
     "@web/test-runner": "^0.18.1",
     "@web/test-runner-playwright": "^0.11.0",
-    "eslint": "^8.57.0",
+    "eslint": "^9.14.0",
     "mocha": "^10.2.0"
   }
 }