Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Google Firebase Crashlytics into iOS App #147

Merged
merged 5 commits into from
Aug 13, 2024

Conversation

matax87
Copy link
Collaborator

@matax87 matax87 commented Aug 13, 2024

Implements #146.

This PR implements the integration of Google Firebase Crashlytics into the iOS app to enhance crash reporting and analysis.
The following changes have been made:

  1. Crashlytics Integration: Google Firebase Crashlytics has been successfully integrated into the iOS app.
    This allows us to receive detailed crash reports, helping us identify and fix issues more efficiently.
  2. dSYMs upload to Crashlytics: added the upload of dSYMs (Debug Symbols) to the Continuous Deployment (CD) GitHub workflow. This is essential for symbolication of crash reports, providing more readable and actionable crash data.
  3. Developer Menu: added a Developer Menu to the app, accessible by shaking the device when the app is running. This menu is included only in builds configured with “Release DEVELOPER_MENU” and “Release TMA DEVELOPER_MENU,” and is not available in the standard “Release” build created via Continuous Deployment (CD). The Developer Menu includes an option to intentionally crash the app, allowing you to verify that Crashlytics correctly receives crash reports.

Testing:

  1. We verified that Crashlytics is correctly receiving crashes from development version of the app (see the screenshot)
  2. Not verified that Crashlytics is correctly receiving crashes from release versions of the app
  3. Not verified that dSYMs are being uploaded successfully as part of the CD pipeline.

@matax87 matax87 requested a review from RudiThoeni August 13, 2024 08:38
@RudiThoeni RudiThoeni merged commit 2a37637 into noi-techpark:main Aug 13, 2024
1 check passed
@matax87 matax87 deleted the feature/add-crashlytics branch August 13, 2024 08:53
@RudiThoeni
Copy link
Member

Merged the PR but the CD did not work we have to agree on some things on the apple developer portal and our account holder is currently on vacation we will do this operations with him next week

@matax87
Copy link
Collaborator Author

matax87 commented Aug 13, 2024

@RudiThoeni the Deploy to TestFlight step of CD has failed because your agent needs to agree to the new Apple contract on the Apple App Store Connect website.

EDIT: Apologies, I missed your previous comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants