Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(playbooks): migration of centurion playbooks to github #17

Merged
merged 11 commits into from
Aug 19, 2024
Merged

feat(playbooks): migration of centurion playbooks to github #17

merged 11 commits into from
Aug 19, 2024

Conversation

jasonpagetas
Copy link
Collaborator

@jasonpagetas jasonpagetas commented Aug 14, 2024 •
edited by jon-nfc
Loading

@jasonpagetas jasonpagetas self-assigned this Aug 14, 2024
@jasonpagetas jasonpagetas added the type::feature type for Issues and Merge Requests. Can also be used in discussion in comments and commits label Aug 14, 2024
@jasonpagetas
Copy link
Collaborator Author

@jon-nfc I think this is ready for a code review before merging / pulling?

@jon-nfc
Copy link
Member

jon-nfc commented Aug 14, 2024

@jon-nfc I think this is ready for a code review before merging / pulling?

nope. where's the documentation on the playbooks usage?

this project is for a product and as such requires additional Items, i.e. documentation

@jon-nfc
Copy link
Member

jon-nfc commented Aug 14, 2024

also the description needs to be updated to include blocking/related/"blocked by" items. see #16 as an example

@jon-nfc jon-nfc mentioned this pull request Aug 14, 2024
Open
6 tasks
@jon-nfc jon-nfc added this to the v1.0.0 milestone Aug 14, 2024
jon-nfc
jon-nfc requested changes Aug 14, 2024
View reviewed changes
playbooks/centurion_teams.yaml Outdated Show resolved Hide resolved
playbooks/centurion_teams.yaml Outdated Show resolved Hide resolved
playbooks/itsm_inventory.yaml Outdated Show resolved Hide resolved
playbooks/itsm_inventory.yaml Outdated Show resolved Hide resolved
playbooks/itsm_inventory.yaml Outdated Show resolved Hide resolved
playbooks/itsm_inventory.yaml Outdated Show resolved Hide resolved
playbooks/itsm_inventory.yaml Outdated Show resolved Hide resolved
@jasonpagetas
Copy link
Collaborator Author

@jon-nfc I think this is ready for a code review before merging / pulling?

nope. where's the documentation on the playbooks usage?

this project is for a product and as such requires additional Items, i.e. documentation

is there a template for the documentation?

Is there a file structure for the doc to go?

@jon-nfc
Copy link
Member

jon-nfc commented Aug 14, 2024

@jon-nfc I think this is ready for a code review before merging / pulling?

nope. where's the documentation on the playbooks usage?
this project is for a product and as such requires additional Items, i.e. documentation

is there a template for the documentation?

Is there a file structure for the doc to go?

docs/projects/ansible/collection/centurion

@jon-nfc jon-nfc mentioned this pull request Aug 14, 2024
Merged
@jon-nfc jon-nfc mentioned this pull request Aug 14, 2024
Merged
jon-nfc added a commit to nofusscomputing/action_ansible_collection that referenced this pull request Aug 14, 2024
@jon-nfc
feat: Initial workflow
d6d0d49 
#1 nofusscomputing/ansible_collection_centurion#17 nofusscomputing/ansible_collection_centurion#18 nofusscomputing/ansible_collection_centurion#15
jon-nfc added a commit that referenced this pull request Aug 14, 2024
@jon-nfc
ci(collection): Add Ansible Collection workflow
baf4b67 
#15 #17 #18 nofusscomputing/action_ansible_collection#1
This was referenced Aug 14, 2024
Open
Merged
This was referenced Aug 15, 2024
Closed
Merged
jon-nfc added a commit to nofusscomputing/action_project that referenced this pull request Aug 15, 2024
@jon-nfc
feat(debug): add var check github.repository
ace6aa9 
#3 nofusscomputing/ansible_collection_centurion#17
@jon-nfc
Copy link
Member

jon-nfc commented Aug 15, 2024

updated to current dev head: 0c7873a

@jon-nfc jon-nfc mentioned this pull request Aug 17, 2024
Closed
3 tasks
jon-nfc
jon-nfc requested changes Aug 17, 2024
View reviewed changes
Copy link
Member

@jon-nfc jon-nfc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that should be enough notes to get you started on the docs

docs/projects/centurion_erp/teams.md Outdated Show resolved Hide resolved
docs/projects/centurion_erp/teams.md Outdated Show resolved Hide resolved
docs/projects/centurion_erp/teams.md Outdated Show resolved Hide resolved
docs/projects/centurion_erp/teams.md Outdated Show resolved Hide resolved
docs/projects/centurion_erp/teams.md Outdated Show resolved Hide resolved
docs/projects/centurion_erp/teams.md Outdated Show resolved Hide resolved
docs/projects/centurion_erp/teams.md Outdated Show resolved Hide resolved
docs/projects/centurion_erp/teams.md Outdated Show resolved Hide resolved
docs/projects/centurion_erp/teams.md Outdated Show resolved Hide resolved
docs/projects/centurion_erp/teams.md Outdated Show resolved Hide resolved
jon-nfc
jon-nfc requested changes Aug 18, 2024
View reviewed changes
Copy link
Member

@jon-nfc jon-nfc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't forget to add to mkdocs.yaml the playbook files so they display within the navigation structure.

docs/projects/ansible/collection/centurion/playbooks/teams.md Outdated Show resolved Hide resolved
docs/projects/ansible/collection/centurion/playbooks/teams.md Outdated Show resolved Hide resolved
docs/projects/ansible/collection/centurion/playbooks/teams.md Outdated Show resolved Hide resolved
docs/projects/ansible/collection/centurion/playbooks/teams.md Outdated Show resolved Hide resolved
docs/projects/ansible/collection/centurion/playbooks/teams.md Outdated Show resolved Hide resolved
docs/projects/ansible/collection/centurion/playbooks/teams.md Outdated Show resolved Hide resolved
docs/projects/ansible/collection/centurion/playbooks/teams.md Outdated Show resolved Hide resolved
docs/projects/ansible/collection/centurion/playbooks/teams.md Outdated Show resolved Hide resolved
docs/projects/ansible/collection/centurion/playbooks/teams.md Outdated Show resolved Hide resolved
@jon-nfc jon-nfc mentioned this pull request Aug 18, 2024
Merged
5 tasks
jon-nfc
jon-nfc requested changes Aug 18, 2024
View reviewed changes
playbooks/inventory.yaml Outdated Show resolved Hide resolved
playbooks/inventory.yaml Show resolved Hide resolved
playbooks/inventory.yaml Outdated Show resolved Hide resolved
playbooks/inventory.yaml Outdated Show resolved Hide resolved
playbooks/inventory.yaml Outdated Show resolved Hide resolved
docs/projects/ansible/collection/centurion/playbooks/index.md Outdated Show resolved Hide resolved
docs/projects/ansible/collection/centurion/playbooks/teams.md Outdated Show resolved Hide resolved
docs/projects/ansible/collection/centurion/playbooks/index.md Outdated Show resolved Hide resolved
docs/projects/ansible/collection/centurion/playbooks/teams.md Outdated Show resolved Hide resolved
playbooks/itsm_inventory.yaml Outdated Show resolved Hide resolved
@jon-nfc jon-nfc mentioned this pull request Aug 18, 2024
Merged
@jasonpagetas jasonpagetas reopened this Aug 19, 2024
@jasonpagetas
Copy link
Collaborator Author

@jon-nfc ready for code review

jon-nfc
jon-nfc requested changes Aug 19, 2024
View reviewed changes
.ansible-lint-ignore Outdated Show resolved Hide resolved
docs/projects/ansible/collection/centurion/playbooks/index.md Show resolved Hide resolved
docs/projects/ansible/collection/centurion/playbooks/inventory.md Outdated Show resolved Hide resolved
docs/projects/ansible/collection/centurion/playbooks/inventory.md Outdated Show resolved Hide resolved
docs/projects/ansible/collection/centurion/playbooks/teams.md Outdated Show resolved Hide resolved
docs/projects/ansible/collection/centurion/playbooks/teams.md Outdated Show resolved Hide resolved
playbooks/inventory.yaml Show resolved Hide resolved
playbooks/teams.yaml Show resolved Hide resolved
docs/projects/ansible/collection/centurion/playbooks/teams.md Outdated Show resolved Hide resolved
docs/projects/ansible/collection/centurion/playbooks/inventory.md Outdated Show resolved Hide resolved
@jasonpagetas
chore(): Update changes from code review
1ef25b3 
Blank lines at end of documents
rewording some docs
Spacing between ansible-lint-ignore rules
Variable names
remove uneccessry info in teams.md
changed description index
changed description teams.md
@jon-nfc jon-nfc merged commit 2d819eb into nofusscomputing:development Aug 19, 2024
2 of 3 checks passed
@jon-nfc jon-nfc deleted the playbooks branch August 19, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jon-nfc jon-nfc jon-nfc approved these changes

Assignees

@jasonpagetas jasonpagetas

Labels
type::feature type for Issues and Merge Requests. Can also be used in discussion in comments and commits
Projects
Centurion ERP
Status: Done
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jasonpagetas @jon-nfc