Skip to content

Commit

Permalink
[Bugfix]Using the correct type hints (vllm-project#9885)
Browse files Browse the repository at this point in the history
Signed-off-by: Gregory Shtrasberg <[email protected]>
  • Loading branch information
gshtras authored Nov 4, 2024
1 parent c49f040 commit b67feb1
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions vllm/sequence.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@
from collections import defaultdict
from dataclasses import dataclass, field
from functools import cached_property, reduce
from typing import TYPE_CHECKING, Any, Callable, Dict, List, Mapping, Optional
from typing import (TYPE_CHECKING, Any, Callable, DefaultDict, Dict, List,
Mapping, Optional)
from typing import Sequence as GenericSequence
from typing import Set, Tuple, Union, cast

Expand Down Expand Up @@ -256,7 +257,8 @@ def output_token_ids(self) -> Tuple[int, ...]:
return tuple(self._output_token_ids)

@output_token_ids.setter
def output_token_ids(self, new_output_token_ids: List[int]) -> None:
def output_token_ids(self,
new_output_token_ids: GenericSequence[int]) -> None:
self._output_token_ids = array(VLLM_TOKEN_ID_ARRAY_TYPE,
new_output_token_ids)
self._update_cached_all_tokens()
Expand Down Expand Up @@ -1173,7 +1175,7 @@ def get_all_seq_ids_and_request_ids(
sequence ids.
"""
seq_ids: List[int] = []
request_id_seq_ids_mapping: Dict[str, Set[int]] = defaultdict(set)
request_id_seq_ids_mapping: DefaultDict[str, Set[int]] = defaultdict(set)
for sg in seq_group_metadata_list:
for seq_id in sg.seq_data:
seq_ids.append(seq_id)
Expand Down

0 comments on commit b67feb1

Please sign in to comment.