push.apply with an unbounded array leads to stack overflow exceptions.

fix for #827
nodeshift · Oct 26, 2023 · 2658da8 · 2658da8
1 parent d644f10
commit 2658da8
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/lib/circuit.js b/lib/circuit.js
@@ -595,7 +595,7 @@ class CircuitBreaker extends EventEmitter {
 
     // If cache is enabled, check if we have a cached value
     if (this.options.cache) {
-      cacheKey = this.options.cacheGetKey.apply(this, rest);
+      cacheKey = this.options.cacheGetKey(...rest);
       const cached = this.options.cacheTransport.get(cacheKey);
       if (cached) {
         /**
@@ -823,8 +823,8 @@ function fallback (circuit, err, args) {
   if (circuit[FALLBACK_FUNCTION]) {
     try {
       const result =
-      circuit[FALLBACK_FUNCTION]
-        .apply(circuit[FALLBACK_FUNCTION], [...args, err]);
+      circuit[FALLBACK_FUNCTION](...args, err);
+
       /**
        * Emitted when the circuit breaker executes a fallback function
        * @event CircuitBreaker#fallback

diff --git a/lib/status.js b/lib/status.js
@@ -106,7 +106,9 @@ class Status extends EventEmitter {
       });
 
       if (this.rollingPercentilesEnabled) {
-        acc.latencyTimes.push.apply(acc.latencyTimes, val.latencyTimes || []);
+        if (val.latencyTimes) {
+          acc.latencyTimes = acc.latencyTimes.concat(val.latencyTimes);
+        }
       }
       return acc;
     }, bucket());