Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support Node.js v20 #78

Merged
merged 1 commit into from
Apr 8, 2024
Merged

feat: support Node.js v20 #78

merged 1 commit into from
Apr 8, 2024

Conversation

10xLaCroixDrinker
Copy link
Contributor

@10xLaCroixDrinker 10xLaCroixDrinker commented Mar 12, 2024

BREAKING CHANGE:
Drop support for Node.js v14
Update prom-client to v15
metrics is now an async function

I matched the Node.js support matrix to opossum. .metrics had to become an async function instead of a getter due to changes in prom-client.

BREAKING CHANGE:
Drop support for Node.js v14
Update prom-client to v15
metrics is now an async function
@10xLaCroixDrinker
Copy link
Contributor Author

@lholmquist can I get some eyes on this?

@10xLaCroixDrinker
Copy link
Contributor Author

@lance @helio-frota Do you think you could review this?

@helio-frota
Copy link
Member

@10xLaCroixDrinker thanks for your contribution 👍

I appreciate being considered for reviewing this PR. However, I wanted to kindly let you know that I'm no longer involved with this project (and node.js in general). While I'd love to contribute in any way I can, I believe it would be best to defer the review to someone currently more involved in the project to ensure it receives the attention it deserves.

Thank you for understanding, and I wish you the best 👍

@lholmquist
Copy link
Member

@10xLaCroixDrinker sorry for the delay, looks like this got buried in my inbox

@lholmquist lholmquist merged commit 1f3e050 into nodeshift:main Apr 8, 2024
6 checks passed
@lholmquist
Copy link
Member

released on npm as 0.4.0

@10xLaCroixDrinker 10xLaCroixDrinker deleted the feature/support-node-20 branch April 8, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants