fix(imap-starttls): define SNICallback only when insecure (closes #635

) (#637)
nodemailer · Feb 26, 2024 · 4b19dee · 4b19dee
1 parent aa60ef9
commit 4b19dee
Showing 1 changed file with 6 additions and 10 deletions.
diff --git a/imap-core/lib/imap-server.js b/imap-core/lib/imap-server.js
@@ -402,21 +402,17 @@ class IMAPServer extends EventEmitter {
         }
 
         if (this.options.secure) {
-            // appy changes
-
+            // apply changes
             Object.keys(defaultTlsOptions || {}).forEach(key => {
                 if (!(key in this.options)) {
                     this.options[key] = defaultTlsOptions[key];
                 }
             });
-
-            // ensure SNICallback method
-            if (typeof this.options.SNICallback !== 'function') {
-                // create default SNI handler
-                this.options.SNICallback = (servername, cb) => {
-                    cb(null, this.secureContext.get(servername));
-                };
-            }
+        } else if (typeof this.options.SNICallback !== 'function') {
+            // ensure SNICallback method and create default SNI handler
+            this.options.SNICallback = (servername, cb) => {
+                cb(null, this.secureContext.get(servername));
+            };
         }
     }