Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: simplified storybook/next config #7280

Merged
merged 3 commits into from
Nov 24, 2024
Merged

Conversation

ovflowd
Copy link
Member

@ovflowd ovflowd commented Nov 23, 2024

This PR simplifies a bit our Next.js config and our Storybook config removing workarounds that are not necessary anymore.

@ovflowd ovflowd requested review from a team as code owners November 23, 2024 16:58
Copy link

vercel bot commented Nov 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Nov 23, 2024 5:10pm

Copy link

github-actions bot commented Nov 23, 2024

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 97 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 99 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟢 98 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 92 🔗

Copy link

github-actions bot commented Nov 23, 2024

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 92%
90.79% (631/695) 72.44% (184/254) 94.53% (121/128)

Unit Test Report

Tests Skipped Failures Errors Time
143 0 💤 0 ❌ 0 🔥 5.523s ⏱️

ovflowd and others added 2 commits November 23, 2024 18:06
Co-authored-by: Augustin Mauroy <[email protected]>
Signed-off-by: Claudio W <[email protected]>
@ovflowd
Copy link
Member Author

ovflowd commented Nov 24, 2024

cc @nodejs/nodejs-website requesting fast-tracking since they are trivial changes.

@ovflowd ovflowd added the fast-track Fast Tracking PRs label Nov 24, 2024
@ovflowd ovflowd merged commit c17fccb into main Nov 24, 2024
21 checks passed
@ovflowd ovflowd deleted the chore/storybook-simplify branch November 24, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-track Fast Tracking PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants