Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added allowDiskUse option in mongodb node #317

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

thobhanifreddy
Copy link

I have added allowDiskUse option by solving part of issue #308.

It was also discussed at stackoverflow

@thobhanifreddy thobhanifreddy changed the title Added allowDiskUse oprion in mongodb node Added allowDiskUse option in mongodb node May 17, 2017
@dceejay
Copy link
Member

dceejay commented May 17, 2017

Thanks for this. Why be so specific ? Are there not other possible options to pass in ? eg batchsize ? Why not just pass in a msg.options property and (in your case) set it to {allowDiskUse:true} ?
It would also make the code simpler '-)

@hardillb
Copy link
Member

Also please do not check in .DS_Store files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants