Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update allowed origins and publish #28

Merged
merged 4 commits into from
Nov 13, 2023
Merged

update allowed origins and publish #28

merged 4 commits into from
Nov 13, 2023

Conversation

Sladuca
Copy link
Contributor

@Sladuca Sladuca commented Nov 13, 2023

Motivation

Solution

Proof

PR Checklist

  • added tests
  • updated documentation
  • added changeset if necessary
  • tested in dev/testnet
  • tested site with snap (we haven't automated this yet)
  • re-built & tested circuits if any of them changed
  • updated contracts storage layout (if contracts were updated)

@Sladuca Sladuca marked this pull request as ready for review November 13, 2023 00:00
@Sladuca Graphite App
Copy link
Contributor Author

Sladuca commented Nov 13, 2023

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@Sladuca Sladuca changed the title publish non-prerelease version update allowed origins and publish Nov 13, 2023
panieldark
panieldark approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@panieldark panieldark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can remove app.nocturnelabs.xyz, but is fine

@Sladuca Sladuca merged commit bb1db57 into main Nov 13, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panieldark panieldark panieldark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sladuca @panieldark