Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wsteth adapter + wsteth/balancer/uniswap fork tests #430

Merged
merged 14 commits into from
Sep 4, 2023
Merged

wsteth adapter + wsteth/balancer/uniswap fork tests #430

merged 14 commits into from
Sep 4, 2023

Conversation

luketchang
Copy link
Contributor

@luketchang luketchang commented Sep 1, 2023 •
edited
Loading

Motivation

Prepare Lido integration

Solution

  • add wsteth adapter contract for dealing with ETH
  • add fork tests for wsteth, balancer, and uniswap
  • add test interfaces for interacting with uniswap and balancer
  • add fork tests to CI

Proof

PR Checklist

  • added tests
  • updated documentation
  • added changeset if necessary
  • tested in dev/testnet
  • tested site with snap (we haven't automated this yet)
  • re-built & tested circuits if any of them changed
  • updated contracts storage layout (if contracts were updated)

@changeset-bot
Copy link

changeset-bot bot commented Sep 1, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: d8e05ea

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
@nocturne-xyz/contracts Minor
@nocturne-xyz/core Patch
@nocturne-xyz/deploy Patch
@nocturne-xyz/frontend-sdk Patch
@nocturne-xyz/bundler Patch
@nocturne-xyz/deposit-screener Patch
@nocturne-xyz/subtree-updater Patch
@nocturne-xyz/test-actor Patch
@nocturne-xyz/idb-kv-store Patch
@nocturne-xyz/local-prover Patch
@nocturne-xyz/snap Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@luketchang Graphite App
Copy link
Contributor Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@luketchang luketchang changed the title WIP: lido fork tests wsteth adapter + wsteth/balancer/uniswap fork tests Sep 2, 2023
@luketchang luketchang marked this pull request as ready for review September 2, 2023 00:16
Sladuca
Sladuca approved these changes Sep 2, 2023
View reviewed changes
packages/contracts/contracts/adapters/WstethAdapter.sol Outdated
/// @title WstethAdapter
/// @author Nocturne Labs
/// @notice Adapter contract for interacting with wsteth. The Handler contract does not support ETH
/// value transfers directly, thus we need a thin adapter for haendling the weth -> eth step
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo haendling

packages/contracts/contracts/test/fork/Wsteth.t.sol Outdated
address(wsteth),
ERC20_ID
),
minRefundValue: wstethExpectedOutAmount - 10 // // TODO: why -10 buffer in case of uneven-ness?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: double comment

@luketchang luketchang enabled auto-merge (squash) September 4, 2023 04:15
@luketchang luketchang merged commit de88d6f into main Sep 4, 2023
4 checks passed
@luketchang luketchang deleted the luke/lido-fork branch September 4, 2023 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sladuca Sladuca Sladuca approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luketchang @Sladuca