Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support node 10+ #129

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

sevenbitbyte
Copy link

Update nan usage

@valpackett
Copy link
Contributor

Still an error with node 14:

/home/greg/.cache/node-gyp/14.5.0/include/node/v8.h:197:5: error: static_assert failed due to requirement 'std::is_base_of<v8::Context, v8::Object>::value' "type check"
    static_assert(std::is_base_of<T, S>::value, "type check");
    ^             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../src/BluetoothHciSocket.cpp:482:18: note: in instantiation of function template specialization 'v8::Local<v8::Context>::Local<v8::Object>' requested here
        obj->Set(obj, Nan::New("devUp").ToLocalChecked(), Nan::New<Boolean>(devUp));
                 ^

@adi1525
Copy link

adi1525 commented Jul 23, 2020

Thank you!
It works on node 10.16.3

You saved me few days for debugging. ;)

Regards,
Adrian

@elggem
Copy link

elggem commented Sep 9, 2020

It worked on Node 10.22.0! When I finally found this it was like magic.
Who can we ping to merge this?

@rzr
Copy link

rzr commented Oct 16, 2020

Is this issue also relevant for this release:

https://www.npmjs.com/package/@abandonware/bluetooth-hci-socket/v/0.5.3-6

@rzr
Copy link

rzr commented Jan 6, 2021

Feel free to comment this related ticket:

abandonware#9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants