-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
imp: adjust build output in Makefile target #446
base: main
Are you sure you want to change the base?
imp: adjust build output in Makefile target #446
Conversation
WalkthroughThe pull request introduces minor modifications to the project's build configuration and documentation link. The Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
Makefile (1)
52-52
: Consider adding directory creation step.While the output path is correct, the build might fail if the
build
directory doesn't exist. Consider adding a directory creation step.build: @echo "🤖 Building nobled..." + @mkdir -p build @go build -mod=readonly $(BUILD_FLAGS) -o "$(PWD)/build/nobled" ./cmd/nobled @echo "✅ Completed build!"
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
Makefile
(1 hunks)tools.go
(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- tools.go
🔇 Additional comments (1)
Makefile (1)
52-52
: LGTM! Output path aligns with local.sh requirements.The change correctly specifies the binary output location as
$(PWD)/build/nobled
, which fulfills the PR objective of making it compatible with thelocal.sh
script.
Problem
When running
make build && sh local.sh
, the script cannot execute because the expected binary is not found:Solution
This PR adjusts the output of the
make build
target to produce the binary at./build/nobled
. Currently, the binary is written to./build
, which does not work with the providedlocal.sh
script, which expects the adjusted path.Other than that, it updates an outdated Go developer wiki link in
tools.go
.