Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump cosmos sdk to v0.50.11 #441

Merged
merged 2 commits into from
Dec 16, 2024
Merged

fix: bump cosmos sdk to v0.50.11 #441

merged 2 commits into from
Dec 16, 2024

Conversation

twothirtyfive
Copy link
Contributor

@twothirtyfive twothirtyfive requested a review from a team as a code owner December 16, 2024 16:44
Copy link

coderabbitai bot commented Dec 16, 2024

Walkthrough

This pull request introduces version 8.0.4 of the Noble project, focusing on two primary updates. The first is an update to the x/authority module to include helper CLI commands. The second is a security-driven bump of the Cosmos SDK to version v0.50.11, addressing security advisories ABS-0043 and ABS-0044. The changes are part of routine maintenance to enhance the project's security and functionality.

Changes

File Change Summary
.changelog/v8.0.4/dependencies/441-bump-sdk.md Added changelog entry for Cosmos SDK version update to v0.50.11
.changelog/v8.0.4/summary.md Added changelog summary for v8.0.4 release dated December 16, 2024
CHANGELOG.md Added v8.0.4 version entry with details on x/authority module and Cosmos SDK updates

Poem

🐰 A Noble update hops along,
SDK bumped, security strong!
CLI helpers dancing bright,
Version 8.0.4 takes flight
Rabbit's code, secure and light 🛡️


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Member

@boojamya boojamya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
.changelog/v8.0.4/summary.md (1)

1-1: Consider using proper markdown heading syntax

Instead of using emphasis (*) for the date, consider using a proper heading format:

-*Dec 16, 2024*
+# Dec 16, 2024
🧰 Tools
🪛 Markdownlint (0.37.0)

1-1: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3ad5f78 and 9297721.

⛔ Files ignored due to path filters (5)
  • e2e/go.mod is excluded by !**/*.mod
  • e2e/go.sum is excluded by !**/*.sum, !**/*.sum
  • go.mod is excluded by !**/*.mod
  • go.sum is excluded by !**/*.sum, !**/*.sum
  • go.work.sum is excluded by !**/*.sum, !**/*.sum
📒 Files selected for processing (3)
  • .changelog/v8.0.4/dependencies/441-bump-sdk.md (1 hunks)
  • .changelog/v8.0.4/summary.md (1 hunks)
  • CHANGELOG.md (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • .changelog/v8.0.4/dependencies/441-bump-sdk.md
🧰 Additional context used
🪛 Markdownlint (0.37.0)
.changelog/v8.0.4/summary.md

1-1: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)

CHANGELOG.md

5-5: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)

🔇 Additional comments (3)
.changelog/v8.0.4/summary.md (1)

1-3: LGTM! Content is accurate and concise

The summary correctly identifies this as a non-consensus breaking patch release.

🧰 Tools
🪛 Markdownlint (0.37.0)

1-1: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)

CHANGELOG.md (2)

3-12: LGTM! Changelog entry is well-structured and complete

The changelog entry:

  • Correctly identifies this as a non-consensus breaking patch
  • Properly documents both dependency updates
  • Includes relevant links to the security advisory and PRs
  • Maintains consistent formatting with previous entries
🧰 Tools
🪛 Markdownlint (0.37.0)

5-5: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)


12-12: Verify security advisory implementation

The changelog correctly references the security advisory. Let's verify the implementation details:

✅ Verification successful

SDK version update properly implemented

The verification confirms that Cosmos SDK v0.50.11 is correctly updated across all relevant files:

  • Primary dependency files (go.mod, go.sum) show v0.50.11
  • E2E testing files (e2e/go.mod, e2e/go.sum) also updated to v0.50.11
  • Historical references in go.work.sum to older versions (v0.50.6, v0.50.9) don't affect the current implementation
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the Cosmos SDK version update in go.mod

# Check for the updated SDK version in go.mod
echo "Checking for Cosmos SDK version v0.50.11..."
rg -l "github.com/cosmos/cosmos-sdk v0.50.11"

# Look for any remaining references to older versions
echo "Checking for any remaining old SDK versions..."
rg "github.com/cosmos/cosmos-sdk v0.50"

Length of output: 1023

@johnletey johnletey changed the title fix: bump cosmos-sdk to v0.50.11 fix: bump cosmos sdk to v0.50.11 Dec 16, 2024
@johnletey johnletey merged commit ff1e521 into main Dec 16, 2024
37 checks passed
@johnletey johnletey deleted the julian/bump-cosmos-sdk branch December 16, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants