-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: bump cosmos sdk to v0.50.11
#441
Conversation
WalkthroughThis pull request introduces version 8.0.4 of the Noble project, focusing on two primary updates. The first is an update to the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.changelog/v8.0.4/summary.md (1)
1-1
: Consider using proper markdown heading syntaxInstead of using emphasis (
*
) for the date, consider using a proper heading format:-*Dec 16, 2024* +# Dec 16, 2024🧰 Tools
🪛 Markdownlint (0.37.0)
1-1: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (5)
e2e/go.mod
is excluded by!**/*.mod
e2e/go.sum
is excluded by!**/*.sum
,!**/*.sum
go.mod
is excluded by!**/*.mod
go.sum
is excluded by!**/*.sum
,!**/*.sum
go.work.sum
is excluded by!**/*.sum
,!**/*.sum
📒 Files selected for processing (3)
.changelog/v8.0.4/dependencies/441-bump-sdk.md
(1 hunks).changelog/v8.0.4/summary.md
(1 hunks)CHANGELOG.md
(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- .changelog/v8.0.4/dependencies/441-bump-sdk.md
🧰 Additional context used
🪛 Markdownlint (0.37.0)
.changelog/v8.0.4/summary.md
1-1: null
Emphasis used instead of a heading
(MD036, no-emphasis-as-heading)
CHANGELOG.md
5-5: null
Emphasis used instead of a heading
(MD036, no-emphasis-as-heading)
🔇 Additional comments (3)
.changelog/v8.0.4/summary.md (1)
1-3
: LGTM! Content is accurate and concise
The summary correctly identifies this as a non-consensus breaking patch release.
🧰 Tools
🪛 Markdownlint (0.37.0)
1-1: null
Emphasis used instead of a heading
(MD036, no-emphasis-as-heading)
CHANGELOG.md (2)
3-12
: LGTM! Changelog entry is well-structured and complete
The changelog entry:
- Correctly identifies this as a non-consensus breaking patch
- Properly documents both dependency updates
- Includes relevant links to the security advisory and PRs
- Maintains consistent formatting with previous entries
🧰 Tools
🪛 Markdownlint (0.37.0)
5-5: null
Emphasis used instead of a heading
(MD036, no-emphasis-as-heading)
12-12
: Verify security advisory implementation
The changelog correctly references the security advisory. Let's verify the implementation details:
✅ Verification successful
SDK version update properly implemented
The verification confirms that Cosmos SDK v0.50.11 is correctly updated across all relevant files:
- Primary dependency files (go.mod, go.sum) show v0.50.11
- E2E testing files (e2e/go.mod, e2e/go.sum) also updated to v0.50.11
- Historical references in go.work.sum to older versions (v0.50.6, v0.50.9) don't affect the current implementation
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify the Cosmos SDK version update in go.mod
# Check for the updated SDK version in go.mod
echo "Checking for Cosmos SDK version v0.50.11..."
rg -l "github.com/cosmos/cosmos-sdk v0.50.11"
# Look for any remaining references to older versions
echo "Checking for any remaining old SDK versions..."
rg "github.com/cosmos/cosmos-sdk v0.50"
Length of output: 1023
v0.50.11
As per: GHSA-8wcc-m6j2-qxvm