Add ComputeEngine Property for choosing Engine #2849
Conversation
jijoongmoon
requested review from
myungjoo,
again4you,
jaeyun-jung,
leemgs,
wooksong,
gichan-jang,
anyj0527,
lhs8928,
songgot,
jihochu,
DonghakPark,
SeoHyungjun,
baek2sm,
skykongkong8,
djeong20 and
EunjuYang
as code owners
| ml::train::LayerComputeEngine | ||
| getComputeEngine(const std::vector<std::string> &props) { |
There was a problem hiding this comment.
Function prototype for getComputeEngine is missing in header. Isn't it required to be declared in header?
There was a problem hiding this comment.
Thanks for your comment. This getComputeEngine function will be removed in PR #2849.
It moved and renamed as "parseComputeEngine"
| #endif | ||
| } | ||
|
|
||
| auto &ac = nntrainer::AppContext::Global(); |
There was a problem hiding this comment.
Do you think it holds for both ml::train::LayerComputeEngine::CPU and ml::train::LayerComputeEngine::QNN?
If not, you may need to add more condition to check it.
I think it would be better to add a case to check QNN with NYI exception.
There was a problem hiding this comment.
No. it doesn't. This will changed in PR #2848 too.
nntrainer/nntrainer/layers/layer_node.cpp
Line 140 in dbbde82
| #endif | ||
| } | ||
|
|
||
| auto &ac = nntrainer::AppContext::Global(); |
This PR add ComputeEngine Enum Property. Enum elements are "cpu", "gpu", "qnn" for now. The property format is "engine=qnn". **Self evaluation:** 1. Build test: [X]Passed [ ]Failed [ ]Skipped 2. Run test: [X]Passed [ ]Failed [ ]Skipped Signed-off-by: jijoong.moon <[email protected]>
jijoongmoon
force-pushed
the
engine_property
branch
from
869d348 to
5a11693
Compare
| // const LayerComputeEngine &compute_engine = LayerComputeEngine::GPU) | ||
| // { | ||
| // return createLayer(LayerType::LAYER_RMSNORM, properties, compute_engine); | ||
| // } |
Add Compute Engine Property
This PR add ComputeEngine Enum Property.
Enum elements are "cpu", "gpu", "qnn" for now.
The property format is "engine=qnn".
Self evaluation:
Signed-off-by: jijoong.moon [email protected]