[FSU] Modify the condition of LoadTensors #2843
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeoHyungjun
requested review from
myungjoo,
jijoongmoon,
again4you,
jaeyun-jung,
leemgs,
wooksong,
gichan-jang,
anyj0527,
lhs8928,
songgot,
jihochu,
DonghakPark,
baek2sm,
skykongkong8,
djeong20 and
EunjuYang
as code owners
DonghakPark
reviewed
Dec 26, 2024
nntrainer/models/neuralnet.cpp
Outdated
| model_graph.LoadTensors(f); | ||
| } | ||
| if (f != 0 && lookahead != 0) | ||
| model_graph.LoadTensors(f); |
There was a problem hiding this comment.
for lookahead = 0 case (on demand)
doesn't we need this code ?
else {
model_graph.LoadTensors(f);
}There was a problem hiding this comment.
Removed the condition Lookahead != 0.
Previously, more layers were loaded into memory than the value of lookahead. I modified the code so that the correct number of layers are loaded. In addition, I removed the conditional statement so that the same code is executed when the value of lookahead is 0 and when it is not. Signed-off-by: SeoHyungjun <[email protected]>
SeoHyungjun
force-pushed
the
mod_fsu_lookahead
branch
from
2f7d404 to
211a622
Compare
Added last_order to manager. last_order stores the last number loaded previously. Modified the logic to load only those that were not previously loaded by using last_order when requesting LoadTensor. Signed-off-by: SeoHyungjun <[email protected]>
|
There is a problem when the lookahead is 0 in the current code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, more layers were loaded into memory than the value of lookahead.
I modified the code so that the correct number of layers are loaded.
In addition, I removed the conditional statement so that the same code is executed
when the value of lookahead is 0 and when it is not.
Signed-off-by: SeoHyungjun [email protected]