Add QNN Op package #1 #2840
Closed
Add QNN Op package #1 #2840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds the source code and directories for qualcomm npu op support. . nntrainer / npu / qnn **Self evaluation:** 1. Build test: [X]Passed [ ]Failed [ ]Skipped 2. Run test: [X]Passed [ ]Failed [ ]Skipped Signed-off-by: jijoong.moon <[email protected]>
jijoongmoon
requested review from
myungjoo,
again4you,
jaeyun-jung,
leemgs,
wooksong,
gichan-jang,
anyj0527,
lhs8928,
songgot,
jihochu,
DonghakPark,
SeoHyungjun,
baek2sm,
skykongkong8,
djeong20 and
EunjuYang
as code owners
| return assigned_int_key; | ||
| } | ||
|
|
||
| void ClContext::initBlasClKernels() { |
There was a problem hiding this comment.
Is this a temporary change due to excessive amount of code in all commits for QNN(including later PRs)?
There was a problem hiding this comment.
This will be chaged in later PR.
There was a problem hiding this comment.
I just check this comment.
I will skip to review the qnn_context for this PR.
EunjuYang
reviewed
Dec 26, 2024
| @@ -45,6 +45,7 @@ option('enable-avx', type: 'boolean', value: true) | |||
| option('enable-opencl', type: 'boolean', value: false) | |||
| option('enable-biqgemm', type: 'boolean', value: false) | |||
| option('enable-benchmarks', type: 'boolean', value : false) | |||
| option('enable-qnn', type: 'boolean', value: true) | |||
There was a problem hiding this comment.
What about setting the default value of enable-qnn as false?
EunjuYang
reviewed
Dec 26, 2024
Comment on lines
+3
to
+8
| * Copyright (C) 2024 Debadri Samaddar <[email protected]> | ||
| * | ||
| * @file cl_context.h | ||
| * @date 23 Feb 2024 | ||
| * @see https://github.com/nnstreamer/nntrainer | ||
| * @author Debadri Samaddar <[email protected]> |
There was a problem hiding this comment.
It seems that you need to update the Copyright for this qnn_context.h
EunjuYang
reviewed
Dec 26, 2024
|
|
||
| namespace nntrainer { | ||
|
|
||
| extern std::mutex cl_factory_mutex; |
There was a problem hiding this comment.
Suggested change
| extern std::mutex cl_factory_mutex; | |
| extern std::mutex qnn_factory_mutex; |
EunjuYang
reviewed
Dec 26, 2024
|
|
||
| namespace nntrainer { | ||
|
|
||
| std::mutex cl_factory_mutex; |
There was a problem hiding this comment.
ditto.
Suggested change
| std::mutex cl_factory_mutex; | |
| std::mutex qnn_factory_mutex; |
EunjuYang
reviewed
Dec 26, 2024
Comment on lines
+15
to
+16
| #ifndef __CL_CONTEXT_H__ | ||
| #define __CL_CONTEXT_H__ |
There was a problem hiding this comment.
It should be updated for qnn_context.h.
Suggested change
| #ifndef __CL_CONTEXT_H__ | |
| #define __CL_CONTEXT_H__ | |
| #ifndef __QNN_CONTEXT_H__ | |
| #define __QNN_CONTEXT_H__ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the source code and directories for qualcomm npu op
support.
. nntrainer / npu / qnn
Self evaluation:
Signed-off-by: jijoong.moon [email protected]