[hotfix] Fix if-else condition for FSU #2836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonghakPark
requested review from
myungjoo,
jijoongmoon,
again4you,
jaeyun-jung,
leemgs,
wooksong,
gichan-jang,
anyj0527,
lhs8928,
songgot,
jihochu,
SeoHyungjun,
baek2sm,
skykongkong8,
djeong20 and
EunjuYang
as code owners
skykongkong8
approved these changes
Dec 24, 2024
Currently, only the forwarding code is distinguished when Train and Swap are enabled. I also added a case where Swap is turned off and only Inference is turned on. **Self evaluation:** 1. Build test: [X]Passed [ ]Failed [ ]Skipped 2. Run test: [X]Passed [ ]Failed [ ]Skipped Signed-off-by: Donghak PARK <[email protected]>
DonghakPark
force-pushed
the
hotfix_fsu
branch
from
8807c92 to
be41221
Compare
djeong20
approved these changes
Dec 24, 2024
myungjoo
reviewed
Dec 24, 2024
| // temperally remain. when we evaluate all for asynch mode, we weill remove | ||
| if (exec_mode == ExecutionMode::TRAIN) { | ||
| if (exec_mode == ExecutionMode::TRAIN or | ||
| (exec_mode == ExecutionMode::INFERENCE and !swap_mode)) { |
There was a problem hiding this comment.
wow... or and and in C++ code. I feel I'm getting old.
myungjoo
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, only the forwarding code is distinguished when Train and Swap are enabled.
I also added a case where Swap is turned off and only Inference is turned on.
Self evaluation: