[GPU/OpenCL] Fused DotCL, Addition and RMS for optimization #2831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the Fused Layer for all above operation Wrote Related Unittest for the above Signed-off-by: Yash Singh <[email protected]>
baek2sm
reviewed
Dec 17, 2024
| auto disable_bias = std::get<props::DisableBias>(*layer_impl_props); | ||
| bool disable_bias_value = disable_bias.empty() || disable_bias.get() == false; | ||
| const Tensor &bias = context.getWeight(weight_idx[FC_RMSParams::bias]); | ||
| // printf("\n*************************************************************************************************************************************\n"); |
There was a problem hiding this comment.
do we need these comments?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fused_fc_norm_cl.cppblas_kernel_interface.cppandblas_kernels.cpp.test/unittest/layers/unittest_layers_fused_fc_rms_cl.cppandtest/input_gen/gen_layer_tests.py. For Reference and Debugging checktest/unittest/layers/layers_golden_tests.cpp.rms_norm_cl_kernelinblas_kernelsdirectory for generalization.TO-DO
Signed-off-by: Yash Singh [email protected]