[ minor ] bugfix in printing error log (model_commo_properties / LossScale) #2825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EunjuYang
requested review from
myungjoo,
jijoongmoon,
again4you,
jaeyun-jung,
leemgs,
wooksong,
gichan-jang,
anyj0527,
lhs8928,
songgot,
jihochu,
DonghakPark,
SeoHyungjun,
baek2sm,
skykongkong8 and
djeong20
as code owners
skykongkong8
approved these changes
Dec 11, 2024
EunjuYang
force-pushed
the
bugfix/loss_scale_error
branch
2 times, most recently
from
7fbf3ca to
a421dc2
Compare
myungjoo
approved these changes
Dec 12, 2024
myungjoo
reviewed
Dec 12, 2024
| @@ -43,7 +43,8 @@ ModelTensorDataType::ModelTensorDataType(ModelTensorDataTypeInfo::Enum value) { | |||
| LossScale::LossScale(float value) { set(value); } | |||
|
|
|||
| bool LossScale::isValid(const float &value) const { | |||
| ml_loge("Loss scale cannot be 0"); | |||
| if (std::fpclassify(value) == FP_ZERO) | |||
| ml_loge("Loss scale cannot be 0"); | |||
There was a problem hiding this comment.
If it's FP_ZERO, return a proper value.
The current return (value != 0) is inappropriate.
There was a problem hiding this comment.
I missed it! Thank you for pointing it out. I updated the part. Thank you.
- This commit fixes a minor error to print error log. - This commit adds a condition to print the error log. Signed-off-by: Eunju Yang <[email protected]>
EunjuYang
force-pushed
the
bugfix/loss_scale_error
branch
from
a421dc2 to
e55ac2c
Compare
myungjoo
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue: #2826
Self evaluation: