[UTIL] fix the bug in nntr parallel run @open sesame 12/02 17:11 #2802
Conversation
jijoongmoon
requested review from
myungjoo,
again4you,
jaeyun-jung,
leemgs,
wooksong,
gichan-jang,
anyj0527,
lhs8928,
songgot,
jihochu,
DonghakPark,
SeoHyungjun,
baek2sm,
skykongkong8,
djeong20 and
EunjuYang
as code owners
|
📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #2802. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/. |
|
|
cibot: 
There was a problem hiding this comment.
Looks fine except for CI.
Rebasing might fix CI (#2807 is merged)
| #else | ||
| unsigned int nntr_num_threads = 1; | ||
| #endif | ||
|
|
There was a problem hiding this comment.
I'd recomment to constify and make it static with the current usage to avoid future misuse.
static const unsigned int nntr_num_threads = ...
jijoongmoon
changed the title
This PR fix the nntr prarallel run. Previously it is not set properly according to NNTR-NUM-THREADS options in meson_options.txt **Self evaluation:** 1. Build test: [X]Passed [ ]Failed [ ]Skipped 2. Run test: [X]Passed [ ]Failed [ ]Skipped Signed-off-by: jijoong.moon <[email protected]>
jijoongmoon
force-pushed
the
nntr_thread
branch
from
f87ba97 to
b316654
Compare
There was a problem hiding this comment.
@jijoongmoon, 💯 All CI checkers are successfully verified. Thanks.
This PR fix the nntr prarallel run. Previously it is not set properly according to NNTR-NUM-THREADS options in meson_options.txt
Self evaluation: