Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Graph] add inplace setting through layer property @open sesame 12/02 14:37 #2796

Merged
merged 1 commit into from
Dec 2, 2024
Merged

[Graph] add inplace setting through layer property @open sesame 12/02 14:37 #2796

merged 1 commit into from
Dec 2, 2024

Conversation

baek2sm
Copy link
Contributor

@baek2sm baek2sm commented Nov 14, 2024

  • now you can set in-place flag through layer property of tensor
    operation layers.
  • rename "initializeInPlaceType" func to "initializeInPlace". now
    "is_inplace" property is set in that function, too.
  • in some layers, support_backwarding flag may be changed by the
    in-place setting.

Self evaluation:

  1. Build test: [X]Passed [ ]Failed [ ]Skipped
  2. Run test: [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: Seungbaek Hong [email protected]

@taos-ci
Copy link

taos-ci commented Nov 14, 2024

📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #2796. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/.

@baek2sm baek2sm added the WIP label Nov 14, 2024
taos-ci
taos-ci approved these changes Nov 14, 2024
View reviewed changes
Copy link

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@baek2sm, 💯 All CI checkers are successfully verified. Thanks.

@baek2sm baek2sm changed the title [WIP][Wait for #2794, #2795][Graph] add inplace setting through layer property [Wait for #2794, #2795][Graph] add inplace setting through layer property Nov 15, 2024
@baek2sm baek2sm removed the WIP label Nov 15, 2024
taos-ci
taos-ci approved these changes Nov 15, 2024
View reviewed changes
Copy link

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@baek2sm, 💯 All CI checkers are successfully verified. Thanks.

skykongkong8
skykongkong8 approved these changes Nov 19, 2024
View reviewed changes
Copy link
Member

@skykongkong8 skykongkong8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With discussions made offline today, lgtm!

@baek2sm baek2sm changed the title [Wait for #2794, #2795][Graph] add inplace setting through layer property [Graph] add inplace setting through layer property Nov 29, 2024
@baek2sm
[Graph] add inplace setting through layer property
3e2326f 
- now you can set in-place flag through layer property of tensor
operation layers.
- rename "initializeInPlaceType" func to "initializeInPlace". now
"is_inplace" property is set in that function, too.
- in some layers, support_backwarding flag may be changed by the
in-place setting.

**Self evaluation:**
1. Build test:   [X]Passed [ ]Failed [ ]Skipped
2. Run test:     [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: Seungbaek Hong <[email protected]>
taos-ci
taos-ci approved these changes Nov 29, 2024
View reviewed changes
Copy link

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@baek2sm, 💯 All CI checkers are successfully verified. Thanks.

djeong20
djeong20 approved these changes Nov 29, 2024
View reviewed changes
Copy link
Contributor

@djeong20 djeong20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

DonghakPark
DonghakPark approved these changes Nov 29, 2024
View reviewed changes
Copy link
Member

@DonghakPark DonghakPark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@jijoongmoon jijoongmoon changed the title [Graph] add inplace setting through layer property [Graph] add inplace setting through layer property @open sesame 12/02 09:37 Dec 2, 2024
@taos-ci
Copy link

taos-ci commented Dec 2, 2024

:octocat: cibot: @baek2sm, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nntrainer/ci/repo-workers/pr-checker/2796-202412020937250.95195698738098-3e2326fc0e6a9dd3c26ce35bc2637304773b42e8/.

@baek2sm baek2sm changed the title [Graph] add inplace setting through layer property @open sesame 12/02 09:37 [Graph] add inplace setting through layer property @open sesame 12/02 14:37 Dec 2, 2024
taos-ci
taos-ci approved these changes Dec 2, 2024
View reviewed changes
Copy link

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@baek2sm, 💯 All CI checkers are successfully verified. Thanks.

@jijoongmoon jijoongmoon merged commit cefce99 into nnstreamer:main Dec 2, 2024
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skykongkong8 skykongkong8 skykongkong8 approved these changes

@djeong20 djeong20 djeong20 approved these changes

@DonghakPark DonghakPark DonghakPark approved these changes

@taos-ci taos-ci taos-ci approved these changes

@myungjoo myungjoo Awaiting requested review from myungjoo myungjoo is a code owner

@jijoongmoon jijoongmoon Awaiting requested review from jijoongmoon jijoongmoon is a code owner

@again4you again4you Awaiting requested review from again4you again4you is a code owner

@jaeyun-jung jaeyun-jung Awaiting requested review from jaeyun-jung jaeyun-jung is a code owner

@leemgs leemgs Awaiting requested review from leemgs leemgs is a code owner

@wooksong wooksong Awaiting requested review from wooksong wooksong is a code owner

@gichan-jang gichan-jang Awaiting requested review from gichan-jang gichan-jang is a code owner

@anyj0527 anyj0527 Awaiting requested review from anyj0527 anyj0527 is a code owner

@lhs8928 lhs8928 Awaiting requested review from lhs8928 lhs8928 is a code owner

@songgot songgot Awaiting requested review from songgot songgot is a code owner

@jihochu jihochu Awaiting requested review from jihochu jihochu is a code owner

@SeoHyungjun SeoHyungjun Awaiting requested review from SeoHyungjun SeoHyungjun is a code owner

@EunjuYang EunjuYang Awaiting requested review from EunjuYang EunjuYang is a code owner

Assignees
No one assigned
Labels
PR/READY2MERGE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@baek2sm @taos-ci @DonghakPark @djeong20 @skykongkong8 @jijoongmoon