Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ unittest/modelfile ] Add res directory when compiled for android unittest #2768

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

skykongkong8
Copy link
Member

  • In modelfile unittest, some .ini files are formulated temporally at res directory on the fly.
  • Previous code did not make res directory, thus fail to write those files.

Resolves:
nntrainerIniTest.backbone_from_different_directory_n

Self evaluation:

  1. Build test: [X]Passed [ ]Failed [ ]Skipped
  2. Run test: [X]Passed [ ]Failed [ ]Skipped

…ittest

- In modelfile unittest, some .ini files are formulated temporally at res directory on the fly.
- Previous code did not make res directory, thus fail to write those files.

**Self evaluation:**
1. Build test:     [X]Passed [ ]Failed [ ]Skipped
2. Run test:     [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: skykongkong8 <[email protected]>
@taos-ci
Copy link

taos-ci commented Oct 24, 2024

📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #2768. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/.

Copy link

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skykongkong8, 💯 All CI checkers are successfully verified. Thanks.

Copy link
Member

@DonghakPark DonghakPark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!
i will fix other backbone TC

Copy link
Collaborator

@jijoongmoon jijoongmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jijoongmoon jijoongmoon merged commit 9813029 into nnstreamer:main Oct 24, 2024
39 checks passed
@skykongkong8 skykongkong8 deleted the wip/modelfile/android branch October 28, 2024 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants